Temporal: Check observability of ordering of GetOptionsObject accesses#4989
Open
jessealama wants to merge 9 commits intotc39:mainfrom
Open
Temporal: Check observability of ordering of GetOptionsObject accesses#4989jessealama wants to merge 9 commits intotc39:mainfrom
jessealama wants to merge 9 commits intotc39:mainfrom
Conversation
ptomato
requested changes
Mar 11, 2026
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Looks good; note I didn't check for exhaustiveness, but I assume you did 😄
We should reduce the duplication before merging, though.
| assert.compareArray(actual, expected, "order of operations"); | ||
| actual.splice(0); // clear | ||
|
|
||
| const expectedOpsForPrimitiveOptions = [ |
Contributor
There was a problem hiding this comment.
There's an opportunity for increasing readability here, if you move this up a bit and then rewrite expected to be something like
const expected = expectedOpsForPrimitiveOptions.concat(["get options.relativeTo"]);Otherwise we have these two long lists and it's difficult to tell at a glance that they are supposed to contain the same items.
This could apply to some of the other tests with long lists as well.
Comment on lines
+88
to
+95
| // Non-integer values to ensure valueOf is called | ||
| const fields2 = TemporalHelpers.propertyBagObserver(actual, { | ||
| year: 1.7, | ||
| month: 1.7, | ||
| monthCode: "M01", | ||
| day: 1.7, | ||
| calendar: "iso8601", | ||
| }, "fields", ["calendar"]); |
Contributor
There was a problem hiding this comment.
I think(?) no need for fields2, you can just reuse fields. The array (actual) that it dumps into has been cleared.
This could apply to some of the other tests as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows up #4987 with tests for observability of
GetOptionsObjectaccesses. There, we tested justPlainYearMonth's.addand.subtract. Here, we follow the same pattern, exercising: