Hopefully uncontroversial clang format changes#339
Open
Conversation
There's not currently any Objective C code in the tree, but if any ever shows up it should be indented in a way to match the C++ code. I should have set this to four in the initial commit of the .clang-format file, but I missed it. This doesn't cause any actual formatting changes currently.
Some rules used 1 space after ':', some used multiple. Some tried to line up values vertically, some didn't. Make the file consistently use 1 space after ':' everywhere.
These options are for a LLVM internal format, not relevant to C++ code and they are conditionally supported based on clang-format build options, so some builds may support them, some builds will not. Also, old clang-format versions may error on encountering an unknown option while newer versions may just ignore them. In any case, these do nothing for us and they may cause problems for some users, so just remove them.
jjuhl
force-pushed
the
hopefully-uncontroversial-clang-format-changes
branch
from
1229f7e to
b7c66a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Texus
Here are some fairly trivial changes to .clang-format for you.
I really should have caught these initially, but for some reason I overlooked them (I guess I was too focused on just landing the change that I neglected some of the minor details).
In any case, these cause no actual formatting changes and should be rather uncontroversial to merge.
:-)