Allow empty API keys for custom OpenAI endpoints in the macOS app#262
Open
ainopara wants to merge 1 commit intotheJayTea:mainfrom
Open
Allow empty API keys for custom OpenAI endpoints in the macOS app#262ainopara wants to merge 1 commit intotheJayTea:mainfrom
ainopara wants to merge 1 commit intotheJayTea:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This PR is specific to the macOS app under
macOS/WritingTools. Other platform implementations live in separate codebases and are not affected.I use LM Studio as a local LLM backend for the macOS app. LM Studio exposes an OpenAI-compatible API, so the macOS app's OpenAI-compatible provider can call it by setting a custom base URL such as a local
localhostendpoint.In this local-provider scenario, an API key is not required. Requiring the API key field to be non-empty prevents otherwise valid OpenAI-compatible local endpoints from working in the macOS app.
Summary
Authorizationheader for custom OpenAI-compatible requests when the API key field is empty.Testing
xcodebuild -project macOS/WritingTools.xcodeproj -scheme WritingTools -configuration Release -destination 'platform=macOS'.