ASoC: SOF: topology: allow user to add topologies by module parameter#5682
ASoC: SOF: topology: allow user to add topologies by module parameter#5682bardliao wants to merge 2 commits intothesofproject:topic/sof-devfrom
Conversation
The virtual loop dai link is created by the machine driver and no topology is needed for the dai link. Handle it to avoid the dai_link is not supported error. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
bardliao
requested review from
dbaluta,
kv2019i,
lgirdwood,
plbossart and
ranj063
as code owners
|
An example to test the user topologies: |
bardliao
force-pushed
the
function-topology-echo-ref-alternative
branch
from
c3616a9 to
cdedb94
Compare
sound/soc/sof/topology.c
Outdated
| * snd_soc_tplg_component_remove(scomp) here. | ||
| */ | ||
| dev_err(scomp->dev, "tplg request firmware %s failed err: %d\n", | ||
| tplg_files[i], ret); |
There was a problem hiding this comment.
request_firmware() warns on error already.
OK, we print similar error previously, should we note that this is user tplg request? It will be easier to see where the exact line where we failed.
There was a problem hiding this comment.
Sure, I will edit the trace to specify it is a user defined topology.
sound/soc/sof/topology.c
Outdated
| */ | ||
| dev_err(scomp->dev, "tplg request firmware %s failed err: %d\n", | ||
| tplg_files[i], ret); | ||
| goto out; |
There was a problem hiding this comment.
but, do we really want to fail if the base topologies are already loaded and ready?
I would think that we should warn and ignore the errors, what do you think?
There was a problem hiding this comment.
That is a good question. I think when a user adds the topology by module parameters means he needs it. Personally, I prefer return error to make sure the user notice the issue. But I am open on it.
bardliao
force-pushed
the
function-topology-echo-ref-alternative
branch
2 times, most recently
from
3967c0c to
1581a65
Compare
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
LGTM, one comment not a blocker.
sound/soc/sof/topology.c
Outdated
| module_param(disable_function_topology, bool, 0444); | ||
| MODULE_PARM_DESC(disable_function_topology, "Disable function topology loading"); | ||
|
|
||
| #define MAX_FEATURE_TPLG_COUNT 5 |
There was a problem hiding this comment.
seems a little low, e.g. we may have multiple endpoint and 3P processing, maybe safe to say 16 ?
Currently, the function topology provides the basic audio function. The commit allow the users add their topologies to the topology list. So they can add their own features. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
bardliao
force-pushed
the
function-topology-echo-ref-alternative
branch
from
1581a65 to
312c19d
Compare
3 participants
The virtual loop dai link is created by the machine driver and no topology is needed for the dai link. Handle it to avoid the dai_link is not supported error.
Currently, the function topology provides the basic audio function. The commit allow the users add their topologies to the topology list. So they can add their own features.