ASoC: SOF: ipc4-topology: Print for format type in dbg_audio_format#5693
Open
ujfalusi wants to merge 1 commit intothesofproject:topic/sof-devfrom
Open
ASoC: SOF: ipc4-topology: Print for format type in dbg_audio_format#5693ujfalusi wants to merge 1 commit intothesofproject:topic/sof-devfrom
ujfalusi wants to merge 1 commit intothesofproject:topic/sof-devfrom
Conversation
ujfalusi
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart and
ranj063
as code owners
ujfalusi
force-pushed
the
peter/sof/pr/ipc4-type-thing-fix-02
branch
from
7e78e08 to
5ab0997
Compare
ujfalusi
changed the title
bardliao
reviewed
Mar 18, 2026
sound/soc/sof/ipc4-topology.c
Outdated
|
|
||
| static u32 sof_ipc4_fmt_cfg_to_type(u32 fmt_cfg) | ||
| { | ||
| /* Fetch the sample type from the fmt for 8 and 32 bit formats */ |
Collaborator
There was a problem hiding this comment.
Nit pick: two spaces between "Fetch" and "the"
Collaborator
Author
There was a problem hiding this comment.
it was in the original patch which added it, I'm moving it up to be usable in other places, I can fix the comment, let me do that.
bardliao
previously approved these changes
Mar 18, 2026
ujfalusi
force-pushed
the
peter/sof/pr/ipc4-type-thing-fix-02
branch
from
5ab0997 to
ad4b870
Compare
8 and 32 bit formats can have different types, print them in debug information to have complete view of the supported formats. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Collaborator
Author
|
Changes since v1:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
8 and 32 bit formats can have different types, print them in debug information to have complete view of the supported formats.
Fixes: c04c2e8 ("ASoC: SOF: ipc4-topology: Add support for 8-bit formats")
Cc: stable@vger.kernel.org