audio: mux: fix input buffer consumption for mixed channel counts#10631
Open
abonislawski wants to merge 1 commit intothesofproject:mainfrom
Open
audio: mux: fix input buffer consumption for mixed channel counts#10631abonislawski wants to merge 1 commit intothesofproject:mainfrom
abonislawski wants to merge 1 commit intothesofproject:mainfrom
Conversation
Fix per-source consumed byte accounting in mux_process(). When MUX inputs use different channel counts, using the first input buffer frame size for all consumed accounting advances other source buffers incorrectly. This causes duplicated samples, incorrect output frequency, and capture duration issues. Compute consumed bytes per input buffer using each source stream's own frame size. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect per-source input buffer consumption accounting in mux_process() when mux inputs have different channel counts, preventing buffer drift that can lead to duplicated samples and timing/capture length issues.
Changes:
- Removes the single
source_bytescalculation derived from the first input stream. - Computes
consumedbytes per input buffer using that source stream’s own frame size. - Keeps sink production accounting (
sink_bytes) unchanged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tmleman
approved these changes
Mar 19, 2026
lgirdwood
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix per-source consumed byte accounting in mux_process().
When MUX inputs use different channel counts, using the first input buffer frame size for all consumed accounting advances other source buffers incorrectly. This causes duplicated samples, incorrect output frequency, and capture duration issues.
Compute consumed bytes per input buffer using each source stream's own frame size.