fix(security): upgrade axios from 0.18.1 to 0.21.4 to address critical vulnerability#3904
Open
piotr-roslaniec wants to merge 1 commit intomainfrom
Open
fix(security): upgrade axios from 0.18.1 to 0.21.4 to address critical vulnerability#3904piotr-roslaniec wants to merge 1 commit intomainfrom
piotr-roslaniec wants to merge 1 commit intomainfrom
Conversation
…ability The @openzeppelin/upgrades package required axios@^0.18.0 which resolved to the vulnerable 0.18.1 version. This commit adds npm overrides and yarn resolutions to force resolution to axios 0.21.x across all affected projects. Affected projects: - solidity-v1 (npm) - solidity-v1/dashboard (npm) - solidity/ecdsa (npm + yarn) - solidity/random-beacon (yarn) - token-stakedrop (npm) - infrastructure/eth-networks/scripts (npm) - infrastructure/gcp/keep-faucet (npm) - infrastructure/kube/provision-keep-client (npm)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades
axiosfrom vulnerable0.18.1to0.21.4to address a critical security vulnerability.Root Cause
@openzeppelin/upgrades@2.7.2depends onaxios@^0.18.0. Since upgrading@openzeppelin/upgradesto the latest version doesn't resolve this (it still usesaxios@^0.18.0), we use npmoverridesand yarnresolutionsto force the axios version.Changes
overrideswith nested syntax to target axios within@openzeppelin/upgradesresolutionsfor yarn-based projectsAffected Projects
solidity-v1/solidity-v1/dashboard/token-stakedrop/solidity/ecdsa/solidity/random-beacon/infrastructure/gcp/keep-test/google-functions/keep-faucet/infrastructure/eth-networks/scripts/infrastructure/kube/templates/keep-client/initcontainer/provision-keep-client/Verification
axios@0.18.xremainsaxios@0.21.4Fixes: ENG-623