Support Modern Panda3D, CMake, and Visual Studio.#18
Open
thetestgame wants to merge 1 commit intotobspr:masterfrom
Open
Support Modern Panda3D, CMake, and Visual Studio.#18thetestgame wants to merge 1 commit intotobspr:masterfrom
thetestgame wants to merge 1 commit intotobspr:masterfrom
Conversation
thetestgame
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm sure there will likely be feedback but I'm considering this a first attempt at upgrading the module builder for the latest Visual Studio, CMake, and Panda3D so I can continue to do C++ development for the engine.
Visual Studio version detection and support:
MSVC_VERSION_SHORTinCMakeLists.txtto support Visual Studio versions up to 2026 (vc144), with improved logic and warnings for unknown versions.scripts/common.pyto include all minor versions of 2022 (vc143) and added entries for the upcoming 2026 release (vc144).Interrogate binary discovery and error handling:
scripts/common.pyto locate theinterrogatebinary by first checking pip-installed locations, then the system PATH, and finally the SDK, with clear error messages and installation hints if not found.CMakeLists.txtwheninterrogateis missing, now suggesting installation via pip for easier troubleshooting.Build and setup robustness:
scripts/setup.pyto check for the presence of thep3interrogatedblibrary and fall back tolibpandaif not available, improving compatibility with newer Panda3D SDKs.