Document MySQL DSN password URL-encoding requirement#1692
Merged
josecelano merged 1 commit intotorrust:developfrom Apr 17, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1692 +/- ##
========================================
Coverage 86.50% 86.51%
========================================
Files 288 288
Lines 22672 22672
Branches 22672 22672
========================================
+ Hits 19613 19614 +1
Misses 2833 2833
+ Partials 226 225 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d6c1f97 to
bcbef65
Compare
Member
Author
|
ACK bcbef65 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document that MySQL DSN passwords must be percent-encoded when they contain reserved URL characters.
Changes
Why
Deployments commonly build DSNs from environment variables. Generated secrets can include characters like
+and/, which break DSN parsing unless encoded.Fixes #1606