Conversation
miyatakazuya
left a comment
There was a problem hiding this comment.
Big thanks for fixing this. I've noticed some extraneous comments + potential bug on the path generation timeout. I didn't SITL test it yet, but should be addressed.
Also looking at the TODOs on the PR, I think the need to add a "path generation" tick is urgent. As is, if the path generation does time out and return nullptr, the isMissionFinished() may still be true because a new mission isn't uploaded yet, which would cause the lap count to decrement without the path generation succeeding.
…, chore: made config const
miyatakazuya
left a comment
There was a problem hiding this comment.
The change to MissionState is great. Much better way to modify the mission.
I do think that we still have the flaw where if the path generation times out, the tick() function will just rerun since I think the LOG_F(ERROR,...) doesnt actually exit the code which breaks the numlaps logic if the MissionFinished is not updated properly which it likely is not since a mission did not get uplodaded. Again this should be addressed via a different tick, but a bandaid solution would to stop execution if the path generation finished OR have state var in the tick like is_generating_path which if true does not decrement the laps.
Or we could just work on the new tick feature, assuming the path code will not time out for now lol. Fine with either, but @kimichenn should sitl test this b/c my ubuntu docker env is acting up and i need to fix it.
oops, I meant to put decrement path after it succesfully generated a new path. |

MUST MERGE MAV UPDATES BEFORE THIS
closes #341
staticto get current plane locationTesting
path_planning,coverage_pathing,airdrop_approach<-- terrible naming scheme)TODO