tkldev-setup: resolve repo refs per series with safe fallbacks#45
Open
marcos-mendez wants to merge 1 commit intoturnkeylinux-apps:masterfrom
Open
tkldev-setup: resolve repo refs per series with safe fallbacks#45marcos-mendez wants to merge 1 commit intoturnkeylinux-apps:masterfrom
marcos-mendez wants to merge 1 commit intoturnkeylinux-apps:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an incremental fix for tracker issue #1831.
tkldev-setupalready derives a series ref from the installed TKL version and uses that for some core repos, but repo ref handling is still inconsistent and can still depend on moving default branches in some cases.This patch makes repo ref resolution more consistent by using per-repo series-aware fallback logic, preferring:
${series}${series}-devmasterThis keeps older TKLDev releases from unnecessarily following a moving default branch where a matching series ref exists, while still preserving compatibility with repos that only provide
master.This does not attempt to solve every aspect of #1831, but it should be a useful incremental improvement that is small enough to review and test.