Remove EffectCompat from Test signature.#305
Merged
zainab-ali merged 3 commits intotypelevel:mainfrom Apr 20, 2026
Merged
Conversation
majk-p
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
EffectCompattypeclass combinesAsyncandParallelinstances, and has a few overridable helper functions.In particular, the
realTimeMillisfunction is used to override the clock time when testing.EffectCompatis present in theTestclass signature. Users who implement their ownSharedResourceSuitemust construct aTest, so must have access to anEffectCompat. This can be confusing.This PR replaces
EffectCompatimplicit with cats-effect typeclasses. TheEffectCompatinstance is deconstructed intoClock,DeferandConcurrent, such that theClockcan be replaced during testing.