Draft
Conversation
80d5a28 to
dba641f
Compare
dba641f to
a72b809
Compare
zainab-ali
commented
Apr 20, 2026
| def spec(args: List[String]): Stream[F, TestOutcome] | ||
| } | ||
|
|
||
| @RunWith(classOf[weaver.junit.WeaverRunner]) |
Contributor
Author
There was a problem hiding this comment.
This diff is hard to read, but the changes are as follows:
- The
analyzefunction has been moved fromRunnableSuitetoSharedResourceSuite. This is private to weaver. - The public
isCIfunction has been moved toSharedResourceSuite. Users ofDisciplineFSuitethat are callingisCI(assuming there are any) will have to implement their ownisCIfunction. Arguably, this shouldn't be part of the public API in the first place. - The
RunnableSuitehas been moved into JVM sources. Users who refer toRunnableSuitein cross-platform builds should refer toEffectSuiteinstead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
RunnableSuiteclass is used to integrate with JUnit. It provides:planfunction, for creating a list of tests to runrunUnsafefunction for running tests, only used in JUnitRunWithannotation linking it to theWeaverRunner.It is currently shared across all platforms, but is only required for the JVM.
This introduces some redundancies in the JS and Native implementations. As an example,
unsafeRunSyncis only needed in the JVM implementation, but needs to be implemented for JS and Native.This PR moves
RunnableSuiteinto thejvmsources. Suites that extendRunnableSuite(SharedResourceSuiteandDisciplineFSuite) have correspondingCompattraits that either extendRunnableSuiteorEffectSuite.