Skip to content

Migrate custom SVG sprite icons to lucide-react#353

Merged
ujiro99 merged 3 commits intomainfrom
copilot/migrate-icons-to-lucide
Apr 1, 2026
Merged

Migrate custom SVG sprite icons to lucide-react#353
ujiro99 merged 3 commits intomainfrom
copilot/migrate-icons-to-lucide

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 1, 2026

Removes the custom SVG sprite system (icons.svg + Icon.tsx) from the extension package and replaces all usages with lucide-react components, which was already a listed dependency.

Icon mapping

Old (<Icon name="...">) New (lucide-react)
open-outline ExternalLink
chevron ChevronRight
close X
refresh RefreshCw
check Check
error AlertCircle
copy Copy

Changes

  • Deleted src/icons.svg and src/components/Icon.tsx
  • Entry points (content_script.tsx, options_page.tsx): removed SVG sprite injection (shadow.innerHTML = icons, insertAdjacentHTML, icons.css load)
  • Components (OpenInTab, Menu, ResultPopup, MenuItem, TextStyle, InvisibleItem): replaced <Icon name="..."> with the corresponding Lucide component
  • CSS (OpenInTab.css, Menu.module.css, ResultPopup.module.css): replaced fill with color and transition: fill with transition: color — Lucide SVGs use stroke="currentColor" rather than fill

Copilot AI linked an issue Apr 1, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Replace icons.svg with Lucide icons Migrate custom SVG sprite icons to lucide-react Apr 1, 2026
Copilot AI requested a review from ujiro99 April 1, 2026 01:33
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.17%. Comparing base (eb21e53) to head (476e5c8).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...es/extension/src/components/menu/InvisibleItem.tsx 0.00% 4 Missing ⚠️
...ackages/extension/src/components/menu/MenuItem.tsx 0.00% 4 Missing ⚠️
packages/extension/src/components/OpenInTab.tsx 0.00% 3 Missing ⚠️
...ages/extension/src/components/result/TextStyle.tsx 0.00% 3 Missing ⚠️
packages/extension/src/components/menu/Menu.tsx 0.00% 2 Missing ⚠️
...es/extension/src/components/result/ResultPopup.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #353   +/-   ##
=======================================
  Coverage   25.17%   25.17%           
=======================================
  Files         324      323    -1     
  Lines       31863    31847   -16     
  Branches     1559     1558    -1     
=======================================
- Hits         8020     8019    -1     
+ Misses      23843    23828   -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

1 similar comment
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.17%. Comparing base (eb21e53) to head (476e5c8).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...es/extension/src/components/menu/InvisibleItem.tsx 0.00% 4 Missing ⚠️
...ackages/extension/src/components/menu/MenuItem.tsx 0.00% 4 Missing ⚠️
packages/extension/src/components/OpenInTab.tsx 0.00% 3 Missing ⚠️
...ages/extension/src/components/result/TextStyle.tsx 0.00% 3 Missing ⚠️
packages/extension/src/components/menu/Menu.tsx 0.00% 2 Missing ⚠️
...es/extension/src/components/result/ResultPopup.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #353   +/-   ##
=======================================
  Coverage   25.17%   25.17%           
=======================================
  Files         324      323    -1     
  Lines       31863    31847   -16     
  Branches     1559     1558    -1     
=======================================
- Hits         8020     8019    -1     
+ Misses      23843    23828   -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ujiro99 ujiro99 marked this pull request as ready for review April 1, 2026 02:23
@ujiro99 ujiro99 merged commit 743fa0b into main Apr 1, 2026
5 of 6 checks passed
@ujiro99 ujiro99 deleted the copilot/migrate-icons-to-lucide branch April 1, 2026 02:23
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.17%. Comparing base (eb21e53) to head (476e5c8).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...es/extension/src/components/menu/InvisibleItem.tsx 0.00% 4 Missing ⚠️
...ackages/extension/src/components/menu/MenuItem.tsx 0.00% 4 Missing ⚠️
packages/extension/src/components/OpenInTab.tsx 0.00% 3 Missing ⚠️
...ages/extension/src/components/result/TextStyle.tsx 0.00% 3 Missing ⚠️
packages/extension/src/components/menu/Menu.tsx 0.00% 2 Missing ⚠️
...es/extension/src/components/result/ResultPopup.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #353   +/-   ##
=======================================
  Coverage   25.17%   25.17%           
=======================================
  Files         324      323    -1     
  Lines       31863    31847   -16     
  Branches     1559     1558    -1     
=======================================
- Hits         8020     8019    -1     
+ Misses      23843    23828   -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

icons.svgをLucideへ移行する

2 participants