Migrate custom SVG sprite icons to lucide-react#353
Conversation
Agent-Logs-Url: https://github.com/ujiro99/selection-command/sessions/8575431a-a019-4e20-8fbb-62bdb9bfef05 Co-authored-by: ujiro99 <677231+ujiro99@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
=======================================
Coverage 25.17% 25.17%
=======================================
Files 324 323 -1
Lines 31863 31847 -16
Branches 1559 1558 -1
=======================================
- Hits 8020 8019 -1
+ Misses 23843 23828 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 similar comment
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
=======================================
Coverage 25.17% 25.17%
=======================================
Files 324 323 -1
Lines 31863 31847 -16
Branches 1559 1558 -1
=======================================
- Hits 8020 8019 -1
+ Misses 23843 23828 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
=======================================
Coverage 25.17% 25.17%
=======================================
Files 324 323 -1
Lines 31863 31847 -16
Branches 1559 1558 -1
=======================================
- Hits 8020 8019 -1
+ Misses 23843 23828 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Removes the custom SVG sprite system (
icons.svg+Icon.tsx) from the extension package and replaces all usages with lucide-react components, which was already a listed dependency.Icon mapping
<Icon name="...">)open-outlineExternalLinkchevronChevronRightcloseXrefreshRefreshCwcheckCheckerrorAlertCirclecopyCopyChanges
src/icons.svgandsrc/components/Icon.tsxcontent_script.tsx,options_page.tsx): removed SVG sprite injection (shadow.innerHTML = icons,insertAdjacentHTML,icons.cssload)OpenInTab,Menu,ResultPopup,MenuItem,TextStyle,InvisibleItem): replaced<Icon name="...">with the corresponding Lucide componentOpenInTab.css,Menu.module.css,ResultPopup.module.css): replacedfillwithcolorandtransition: fillwithtransition: color— Lucide SVGs usestroke="currentColor"rather thanfill