Open
Conversation
The build was happening implicitly via npm's prepublishOnly hook, which made it easy to miss when reading the workflow. Add an explicit `npm run build` step so the release pipeline mirrors CI and fails loudly if tsc breaks.
- Replace package-lock.json with bun.lock (bun 1.3.11, text format) - Use oven-sh/setup-bun@v2 + `bun install --frozen-lockfile` in both workflows - Run build/typecheck/tests via `bun run` - Keep setup-node + `npm publish --provenance` in release.yml so the sigstore provenance attestation path is unchanged; bun handles the install and build steps
ytkimirti
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related cleanups to the CI/release pipeline:
1. Explicit build step in release workflow
The release workflow was relying on npm's
prepublishOnlyhook to build beforenpm publish. It worked, but was invisible when reading the workflow — someone looking atrelease.ymlwould reasonably conclude there's no build step. Added an explicitbun run buildstep so the pipeline is self-documenting and a failingtscsurfaces as its own named CI step instead of being buried inside publish output.prepublishOnlyinpackage.jsonis left in place as a safety net for manual publishes.2. Switch package manager to bun
package-lock.json, addedbun.lock(bun 1.3.11, text format)oven-sh/setup-bun@v2+bun install --frozen-lockfilebun runrelease.ymlkeepssetup-nodealongsidesetup-bunsonpm publish --provenancestill drives the actual publish — bun doesn't document a--provenanceflag, so the sigstore attestation path is preserved unchangedVerified locally:
bun install,bun run build,bun run typecheckall pass.