Open
Conversation
|
🚀 Deployed on https://deploy-preview-1902--utelecon.netlify.app |
… into 20260306-mail-magazine
seieric
reviewed
Mar 20, 2026
Comment on lines
+71
to
+72
| width: 10rem; | ||
| color: color.$heading-color; |
Member
There was a problem hiding this comment.
こちらも同様にnoticeにあわせる形にするのが良いと考えます。
Suggested change
| width: 10rem; | |
| color: color.$heading-color; | |
| width: 6rem; | |
| color: color.$heading-color; |
| --- | ||
| import type { MarkdownInstance } from "astro"; | ||
| import type { Lang } from "@components/types"; | ||
| import { getLocaleDateString } from "src/lib/util"; |
Member
There was a problem hiding this comment.
noticeに揃える形でYYYY-MM-DD形式とした方がutlecon上での日付表記が統一されて良いと考えます。
Suggested change
| import { getLocaleDateString } from "src/lib/util"; | |
| import { getISODateString } from "src/lib/util"; |
| <ul class="date_list"> | ||
| {yearItems.map(({ date, title, url }) => ( | ||
| <li> | ||
| <span class="date">{getLocaleDateString(date, displayLang, "medium")}</span> |
Member
There was a problem hiding this comment.
noticeに揃える形でYYYY-MM-DD形式とした方がutlecon上での日付表記が統一されて良いと考えます。
Suggested change
| <span class="date">{getLocaleDateString(date, displayLang, "medium")}</span> | |
| <span class="date">{getISODateString(date)}</span> |
| const date = dateMatch ? new Date(`${dateMatch[1]}-${dateMatch[2]}-${dateMatch[3]}`) : new Date(0); | ||
| return { | ||
| date, | ||
| title: archive.frontmatter.breadcrumb.title, |
Member
There was a problem hiding this comment.
バックナンバー一覧に表示される各配信のタイトルはパンくずリストのもので良いのでしょうか？意図したものであれば問題ないです。
Co-authored-by: Seiya Eriguchi <30688855+seieric@users.noreply.github.com>
…utelecon.github.io into 20260306-mail-magazine
dokonosuke
reviewed
Mar 21, 2026
seieric
approved these changes
Mar 22, 2026
… into 20260306-mail-magazine
dokonosuke
approved these changes
Mar 26, 2026
seieric
approved these changes
Mar 26, 2026
cm-ayf
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://deploy-preview-1902--utelecon.netlify.app/mmagazine/
https://deploy-preview-1902--utelecon.netlify.app/mmagazine/archives/