Skip to content

fix: remove getEnv method from Platform#56

Merged
loks0n merged 2 commits intomainfrom
fix-remove-getenv
Mar 31, 2026
Merged

fix: remove getEnv method from Platform#56
loks0n merged 2 commits intomainfrom
fix-remove-getenv

Conversation

@loks0n
Copy link
Copy Markdown
Contributor

@loks0n loks0n commented Mar 31, 2026

Summary

  • Removes the getEnv method from Platform.php
  • Deletes the associated GetEnvTest.php test file

Test plan

  • Verify existing tests pass without GetEnvTest

🤖 Generated with Claude Code

@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Mar 31, 2026

Greptile Summary

This PR removes the getEnv helper method from Platform.php and deletes its corresponding test file. The change is internally clean — there are no remaining callers of getEnv anywhere in the repository.

  • src/Platform/Platform.php: getEnv method removed; the rest of the class is untouched.
  • tests/unit/GetEnvTest.php: associated test deleted alongside the implementation.
  • The only noteworthy point is that this is a public method removal on a published library. Downstream consumers who call $platform->getEnv(...) will encounter a fatal error after upgrading. Depending on the project's versioning policy, this warrants a semver major bump rather than a fix: patch label.

Confidence Score: 5/5

Safe to merge — the removal is internally consistent with no remaining usages; only consideration is the semver versioning convention for the release.

The single finding is a P2 style/process note about the semver implications of removing a public API method; it does not represent a bug, data issue, or correctness problem within the repository code itself.

No files require special attention beyond the versioning note on src/Platform/Platform.php.

Important Files Changed

Filename Overview
src/Platform/Platform.php Removes the public getEnv method; no internal usages remain, but this is a breaking API change for library consumers.
tests/unit/GetEnvTest.php Test file for the removed getEnv method is cleanly deleted alongside the implementation.

Reviews (3): Last reviewed commit: "fix: apply pint style fixes to Platform...." | Re-trigger Greptile

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@loks0n loks0n force-pushed the fix-remove-getenv branch from dc0a177 to 4105043 Compare March 31, 2026 14:34
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@loks0n loks0n merged commit 068ee46 into main Mar 31, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants