Skip to content

wc: introduce IS_POSIXLY_CORRECT static#11853

Open
xtqqczze wants to merge 1 commit intouutils:mainfrom
xtqqczze:static-posixly-correct
Open

wc: introduce IS_POSIXLY_CORRECT static#11853
xtqqczze wants to merge 1 commit intouutils:mainfrom
xtqqczze:static-posixly-correct

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

No description provided.

@xtqqczze xtqqczze force-pushed the static-posixly-correct branch 2 times, most recently from a7364ac to a38075a Compare April 16, 2026 12:51
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 16, 2026

Merging this PR will not alter performance

✅ 309 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing xtqqczze:static-posixly-correct (e82ce7c) with main (01b7177)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 16, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/timeout/timeout-group is no longer failing!

@xtqqczze

This comment was marked as outdated.

@Alonely0
Copy link
Copy Markdown
Contributor

Alonely0 commented Apr 17, 2026

If the benches are so trivial that fetching an env var takes a 5% perf hit, they're not good benches lol. No it's CodSpeed running on a different environment lol. Ignore me.

Copy link
Copy Markdown
Contributor

@Alonely0 Alonely0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

Comment thread src/uu/wc/src/wc.rs
@Alonely0
Copy link
Copy Markdown
Contributor

The new CodSpeed regressions are probably an LLVM thing from the recent update; it's unrelated to wc so I'd ignore it.

@xtqqczze xtqqczze force-pushed the static-posixly-correct branch from c7658b9 to e82ce7c Compare April 18, 2026 20:32
@xtqqczze
Copy link
Copy Markdown
Contributor Author

The CodSpeed regressions disappeared with same runtime environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants