tail: fix panic on write error in bounded_tail#11886
Merged
cakebaker merged 3 commits intouutils:mainfrom Apr 19, 2026
Merged
Conversation
|
GNU testsuite comparison: |
cakebaker
reviewed
Apr 18, 2026
| let ts = TestScenario::new("tail"); | ||
| let at = &ts.fixtures; | ||
|
|
||
| at.write("bigfile", &"x\n".repeat(100_000)); |
Contributor
There was a problem hiding this comment.
I don't know if it's machine-specific, but on my machine I have to use a much higher value (1_100_000) to make this test fail when running it without your changes to tail.rs.
Contributor
Author
There was a problem hiding this comment.
Hey @cakebaker, thank you for your review! I think it's system-specific, but I'd like to use a value high enough to exceed any realistic block size. I bumped it to 1_100_000.
Contributor
|
Thanks for your PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11809
tail huge-file > /dev/fullpanicked withunwrap()attail.rs:594becausebounded_tailandprint_target_sectiondid not propagate write errors.print_target_sectionto returnUResult<()>, replacing.unwrap()with
?bounded_tailto returnUResult<()>and propagate the error to itscaller
test_failed_write_is_reported_on_seekable_input(Linux-only, uses/dev/fullwith a large seekable file to exercise thebounded_tailpath)