Open
Conversation
xtqqczze
reviewed
Apr 18, 2026
| let mut aborted = None; | ||
| let mode = self.output_error_mode.clone(); | ||
| let mut errors = 0; | ||
| self.writers.retain_mut(|writer| { |
Contributor
There was a problem hiding this comment.
this looks quite ugly, could we use a match instead?
Contributor
Author
There was a problem hiding this comment.
do you want to remove retain_mut?
Contributor
There was a problem hiding this comment.
I took a closer look, and found more refactoring: #11893
oech3
force-pushed
the
tee-code
branch
2 times, most recently
from
2e148fb to
bebdf14
Compare
Unable to generate the performance reportThere was an internal error while processing the run's data. We're working on fixing the issue. Feel free to contact us on Discord or at support@codspeed.io if the issue persists. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to simplify tee by some reason. But it is not too easy...