Skip to content

Add Application's health check#552

Merged
openshift-merge-bot[bot] merged 1 commit intovalidatedpatterns:mainfrom
sector2000:add-application-health-check
Apr 20, 2026
Merged

Add Application's health check#552
openshift-merge-bot[bot] merged 1 commit intovalidatedpatterns:mainfrom
sector2000:add-application-health-check

Conversation

@sector2000
Copy link
Copy Markdown
Contributor

@sector2000 sector2000 commented Apr 13, 2026

The health check for Application resources has been removed in ArgoCD since 1.8. See here for more details. Nevertheless it is required when using the app-of-apps patterns and you want to use sync waves among the apps to ensure they are deployed in the proper order, especially during the bootstrap phase.
The downside is that, if one of the children apps is degraded, the whole app-of-apps becomes degraded, and in some cases this might not be desired. For this reason I made the health check optional via the gitops.applicationHealthCheckEnabled parameter of the patterns-operator-config ConfigMap, and by default it is disabled, for backward compatibility.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 13, 2026

Hi @sector2000. Thanks for your PR.

I'm waiting for a validatedpatterns member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sector2000
Copy link
Copy Markdown
Contributor Author

@mbaldessari @darkdoc

@sector2000 sector2000 force-pushed the add-application-health-check branch from 99cef50 to b6f8c2a Compare April 13, 2026 15:14
@sector2000 sector2000 force-pushed the add-application-health-check branch from b6f8c2a to 159263b Compare April 13, 2026 15:32
@sector2000 sector2000 force-pushed the add-application-health-check branch from 159263b to 1c8718d Compare April 13, 2026 16:05
@mbaldessari
Copy link
Copy Markdown
Contributor

/ok-to-test

@sector2000 sector2000 force-pushed the add-application-health-check branch 2 times, most recently from 86cc939 to 4b63800 Compare April 17, 2026 16:45
@sector2000 sector2000 force-pushed the add-application-health-check branch from 1c471a6 to d413b03 Compare April 20, 2026 12:29
@mbaldessari
Copy link
Copy Markdown
Contributor

/ok-to-test

@mbaldessari
Copy link
Copy Markdown
Contributor

/lgtm

@mbaldessari
Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci Bot added the lgtm label Apr 20, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbaldessari, sector2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit d46d402 into validatedpatterns:main Apr 20, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants