Incorporated lptBuyOrder management#7
Open
chrishobcroft wants to merge 1 commit intovideoDAC:masterfrom
Open
Conversation
I'm sure I'm missing a require somewhere...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some comments:
I renamed
claimCollateralAndPaymenttoclaimSellOrderCollateralAndPaymentfor the LptSellOrder management side of things, because it needed to be differentiated from the equivalent function on the LptBuyOrder management side, which I calledclaimBuyOrderPaymentAndCollateral. I consideredreclaimSellOrderCollateralAndClaimPaymentandreclaimBuyOrderPaymentAndClaimCollateralbut found them too long-winded.I did not add tests, but if you want to write them (which I hope you do), then I would be very grateful if you would submit them as a pull request for me to review.
I'm sure I'm missing a
requiresomewhere, or I got something mixed up.