New packages: sstp-client-1.0.20 and network-manager-sstp-1.3.2#58994
New packages: sstp-client-1.0.20 and network-manager-sstp-1.3.2#58994kalelidev wants to merge 4 commits intovoid-linux:masterfrom
Conversation
815cad7 to
4cf70c7
Compare
|
Since this depends on another new package in a separate pull request you should put them together in one request so that CI can build it and merging doesn't require merging two separate PRs. |
Thanks for the heads-up. |
|
I meant to comment this in #59016, since that one depends on this PR. |
@Duncaen Thanks for the heads-up earlier! I've now combined both packages into this PR (#58994):
Closed the separate #59016. CI should now build everything together without dependency issues. |
| --with-gnome | ||
| --with-gtk4 | ||
| --disable-gtk-doc | ||
| --disable-static" |
There was a problem hiding this comment.
remove --prefix and --libdir, those are set already by the gnu-configure buildstyle.
Indent wtih a single space inside of variables.
| find "${DESTDIR}" -name '*.la' -delete | ||
| find "${DESTDIR}" -name '*.a' -delete |
There was a problem hiding this comment.
| find "${DESTDIR}" -name '*.la' -delete | |
| find "${DESTDIR}" -name '*.a' -delete | |
| find "${DESTDIR}" \( -name '*.la' -o -name '*.a' \) -delete |
srcpkgs/sstp-client/template
Outdated
|
|
||
| hostmakedepends="pkg-config libtool" | ||
| makedepends="ppp-devel libevent-devel openssl-devel" | ||
| depends="ppp ca-certificates" |
There was a problem hiding this comment.
Move all those standard dependency variables above short_desc
You can use xnew pkgname from the xtools package to create a new empty template file next time so that variables are ordered consistently.
| makedepends="NetworkManager-devel glib-devel gnutls-devel gtk+3-devel gtk4-devel libnma-devel libsecret-devel ppp-devel sstp-client-devel" | ||
|
|
||
| depends="NetworkManager sstp-client" | ||
|
|
There was a problem hiding this comment.
Please remove all the empty lines between variables here.
|
|
This adds the SSTP client from https://gitlab.com/sstp-project/sstp-client.
This adds support for the SSTP VPN plugin in NetworkManager from https://gitlab.gnome.org/GNOME/network-manager-sstp.
Includes patch to fix obsolete GTK4 spacing in UI generation.
Combined into one PR to resolve dependency for CI/build.
Shared library registration
Added to
common/shlibs:Testing the changes
I tested the changes in this PR: YES
New package
This new package conforms to the package requirements: YES
Local build testing
I built this PR locally for my native architecture, x86_64-glibc
I built this PR locally for these architectures:
aarch64 (cross)