Modify Database Existence Check in entrypoint.sh#475
Open
sebtiz13 wants to merge 1 commit intowallabag:masterfrom
Open
Modify Database Existence Check in entrypoint.sh#475sebtiz13 wants to merge 1 commit intowallabag:masterfrom
sebtiz13 wants to merge 1 commit intowallabag:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current implementation, when using a PostgreSQL database, most Docker containers create the database and the associated user role. This leads to the
DATABASE_EXISTStest inentrypoint.shalways evaluating to true, causing Wallabag to not be installed properly.To address this issue, I propose modifying the test to check if the tables exist instead of just checking if the database exists.
Changes
DATABASE_EXISTSonly handle the database and role creationTABLES_EXISTStest inentrypoint.shto check if the tables exist.install_wallabagfunctionTesting
Related Issues
#412