fix(tooling): remove target branch from pull-request workflow#660
fix(tooling): remove target branch from pull-request workflow#660mkesavan13 merged 1 commit intowebex:nextfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd187c499b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pull_request_target: | ||
| branches: | ||
| - next | ||
|
|
||
| types: [opened, labeled, reopened, synchronize] |
There was a problem hiding this comment.
Restore base-branch restriction on pull_request_target
Removing the branches filter from pull_request_target broadens this privileged workflow to PRs targeting any branch, but the jobs still check out github.event.pull_request.head.sha and run repository code with many secrets exposed at workflow scope. In practice, once a maintainer applies the validated label, untrusted PR code can now execute with secrets for every target branch (not just next), which materially increases secret-exposure risk and CI blast radius for release/hotfix branches.
Useful? React with 👍 / 👎.
COMPLETES # Adhoc
This pull request addresses
Removed the check for branch in pull-request.yml. Allowing feature branches PRs to run pull_request.yml workflow
by making the following changes
Make sure pull requests raised on feature branches run the pull_request.yml workflow
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging
Make sure to have followed the contributing guidelines before submitting.