Skip to content

refactor: extracted pure functions from background effects handler and controller [WPB-23253]#20974

Open
zskhan wants to merge 2 commits intodevfrom
refactor/background-effect
Open

refactor: extracted pure functions from background effects handler and controller [WPB-23253]#20974
zskhan wants to merge 2 commits intodevfrom
refactor/background-effect

Conversation

@zskhan
Copy link
Copy Markdown
Contributor

@zskhan zskhan commented Apr 13, 2026

TaskWPB-23253 Bring Blurred Background Spike into Webapp Edge

Summary

  • What did I change and why?
    Extracted pure functions from background effects handler and also from the background effects controller and wrote few more tests
  • Risks and how to roll out / roll back (e.g. feature flags):

Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 13, 2026

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 12
  • Failed: 0
  • Skipped: 0
  • 🔁 Flaky: 2
  • 📊 Total: 14
  • Total Runtime: 780.1s (~ 13 min 0 sec)
specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Group Video call (tags: TC-8637, crit-flow-web)
specs/CriticalFlow/oneOnOneCall-TC-8754.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ 1:1 Video call with device switch and screenshare (tags: TC-8754, crit-flow-web)

@zskhan zskhan force-pushed the refactor/background-effect branch from 269dc8f to 99e4f6c Compare April 14, 2026 10:45
@zskhan zskhan force-pushed the refactor/background-effect branch from 99e4f6c to a15cbf2 Compare April 16, 2026 09:54
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants