Skip to content

feat: add state-machine for appLockflow [WPB-23186]#21005

Open
e-maad wants to merge 5 commits intodevfrom
feat/add-app-lock-state-machine-WPB-23186
Open

feat: add state-machine for appLockflow [WPB-23186]#21005
e-maad wants to merge 5 commits intodevfrom
feat/add-app-lock-state-machine-WPB-23186

Conversation

@e-maad
Copy link
Copy Markdown
Contributor

@e-maad e-maad commented Apr 15, 2026

StoryWPB-23186 [Web] Applock forgot password - Users prompted to log out, log in, set new applock password

Summary

Added state machine for appLock flow
https://stately.ai/registry/editor/5b37cbe9-127b-4b50-b3bb-3ffec900e2b6?mode=Simulate&machineId=9d4336ce-95a7-47a3-94a5-2ee7288d31a3
Screenshot 2026-04-15 at 21 04 39

Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.61%. Comparing base (c0b9bb5) to head (634e460).
⚠️ Report is 9 commits behind head on dev.

Files with missing lines Patch % Lines
...app/src/script/page/AppLock/appLockStateMachine.ts 90.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #21005      +/-   ##
==========================================
+ Coverage   44.58%   44.61%   +0.02%     
==========================================
  Files        1696     1697       +1     
  Lines       43893    43923      +30     
  Branches     9036     9043       +7     
==========================================
+ Hits        19571    19597      +26     
- Misses      22269    22270       +1     
- Partials     2053     2056       +3     
Flag Coverage Δ
app_webapp 42.66% <90.00%> (+0.03%) ⬆️
lib_api_client 51.88% <ø> (ø)
lib_core 58.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...app/src/script/page/AppLock/appLockStateMachine.ts 90.00% <90.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 14
  • Failed: 0
  • Skipped: 0
  • 🔁 Flaky: 0
  • 📊 Total: 14
  • Total Runtime: 551.5s (~ 9 min 11 sec)

Comment thread apps/webapp/src/script/page/AppLock/appLockStateMachine.ts Outdated
Comment thread apps/webapp/src/script/page/AppLock/appLockStateMachine.ts
Comment thread apps/webapp/src/script/page/AppLock/appLockStateMachine.ts Outdated
@screendriver
Copy link
Copy Markdown
Member

I think this pull request would be easier to review and safer to roll back if the CI / dependency-management changes were separated from the product behavior changes. Right now the branch combines app-lock work with workflow and automation updates, which makes review scope larger than necessary.

Comment thread apps/webapp/src/script/page/AppLock/appLockStateMachine.ts Outdated
Comment thread apps/webapp/src/script/page/AppLock/appLockStateMachine.ts Outdated
@e-maad e-maad requested a review from screendriver April 16, 2026 20:41
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants