Reader: defer likers row until post body renders (CMM-2049)#22808
Merged
Reader: defer likers row until post body renders (CMM-2049)#22808
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
|
|
Contributor
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #22808 +/- ##
==========================================
- Coverage 37.15% 37.15% -0.01%
==========================================
Files 2314 2314
Lines 124297 124294 -3
Branches 16882 16882
==========================================
- Hits 46188 46185 -3
Misses 74366 74366
Partials 3743 3743 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
Two spinners could appear stacked in the Reader post detail while a post was loading: the inline likers-faces spinner in the header and the WebView content spinner above the body. Gate the likers row on hasWebViewContent so it only appears once the body has laid out, and drop the now-unused inline progress bar (and its showLoading state) from the likers train. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
f2aaebe to
667478e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Fixes CMM-2049.
When loading a Reader post detail, two progress spinners could briefly appear stacked in the upper portion of the screen — the inline likers-faces spinner in the post header and the WebView content spinner above the body.
This PR defers the likers row until the WebView has laid out (
hasWebViewContent = true) and ditches the likers progress spinner.Testing instructions
Note: The merged PR #22807 makes testing this one easier since it gives a quick way to reset the reader DB.
Before
progress-before.mp4
After
progress-after.mp4