Skip to content

Reader: defer likers row until post body renders (CMM-2049)#22808

Merged
nbradbury merged 1 commit intotrunkfrom
issue/CMM-2049-reader-multiple-progress
Apr 22, 2026
Merged

Reader: defer likers row until post body renders (CMM-2049)#22808
nbradbury merged 1 commit intotrunkfrom
issue/CMM-2049-reader-multiple-progress

Conversation

@nbradbury
Copy link
Copy Markdown
Contributor

@nbradbury nbradbury commented Apr 21, 2026

Description

Fixes CMM-2049.

When loading a Reader post detail, two progress spinners could briefly appear stacked in the upper portion of the screen — the inline likers-faces spinner in the post header and the WebView content spinner above the body.

This PR defers the likers row until the WebView has laid out (hasWebViewContent = true) and ditches the likers progress spinner.

Testing instructions

  1. Open the Reader on the Jetpack app
  2. Tap any post in the feed that has likers
  • Verify only a single progress spinner is visible during load (centered above the post body)
  • Verify the likers row does NOT appear before the post body renders
  • Verify the post body renders first, then the likers avatars appear right below the subscribe row
  1. Repeat with a post that has zero likes
  • Verify no likers row appears at all
  1. Repeat with airplane-mode / throttled connectivity so the load is observably slow
  • Verify there is never a moment where two spinners are visible simultaneously

Note: The merged PR #22807 makes testing this one easier since it gives a quick way to reset the reader DB.

Before

progress-before.mp4

After

progress-after.mp4

@dangermattic
Copy link
Copy Markdown
Collaborator

dangermattic commented Apr 21, 2026

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Apr 21, 2026

App Icon📲 You can test the changes from this Pull Request in Jetpack Android by scanning the QR code below to install the corresponding build.

App NameJetpack Android
Build TypeDebug
Versionpr22808-667478e
Build Number1488
Application IDcom.jetpack.android.prealpha
Commit667478e
Installation URL327bv2dg6o9g8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Apr 21, 2026

App Icon📲 You can test the changes from this Pull Request in WordPress Android by scanning the QR code below to install the corresponding build.

App NameWordPress Android
Build TypeDebug
Versionpr22808-667478e
Build Number1488
Application IDorg.wordpress.android.prealpha
Commit667478e
Installation URL4gafqjg7jpuuo
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 37.15%. Comparing base (b8792b3) to head (667478e).
⚠️ Report is 1 commits behind head on trunk.

Files with missing lines Patch % Lines
.../ui/reader/viewmodels/ReaderPostDetailViewModel.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #22808      +/-   ##
==========================================
- Coverage   37.15%   37.15%   -0.01%     
==========================================
  Files        2314     2314              
  Lines      124297   124294       -3     
  Branches    16882    16882              
==========================================
- Hits        46188    46185       -3     
  Misses      74366    74366              
  Partials     3743     3743              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from feature/reset-reader-db to trunk April 22, 2026 17:47
Two spinners could appear stacked in the Reader post detail while a
post was loading: the inline likers-faces spinner in the header and
the WebView content spinner above the body. Gate the likers row on
hasWebViewContent so it only appears once the body has laid out, and
drop the now-unused inline progress bar (and its showLoading state)
from the likers train.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@nbradbury nbradbury force-pushed the issue/CMM-2049-reader-multiple-progress branch from f2aaebe to 667478e Compare April 22, 2026 18:08
@nbradbury nbradbury marked this pull request as ready for review April 22, 2026 18:10
@nbradbury nbradbury requested a review from adalpari April 22, 2026 18:10
Copy link
Copy Markdown
Contributor

@adalpari adalpari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! :shipit:

@nbradbury nbradbury merged commit 79d417d into trunk Apr 22, 2026
27 of 29 checks passed
@nbradbury nbradbury deleted the issue/CMM-2049-reader-multiple-progress branch April 22, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants