feat(remote): Improve remote:curl checksum comparison failure reporting.#108
Open
Bill-hbrhbr wants to merge 1 commit intoy-scope:mainfrom
Open
feat(remote): Improve remote:curl checksum comparison failure reporting.#108Bill-hbrhbr wants to merge 1 commit intoy-scope:mainfrom
remote:curl checksum comparison failure reporting.#108Bill-hbrhbr wants to merge 1 commit intoy-scope:mainfrom
Conversation
Contributor
WalkthroughReplaced a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Currently, this task verified downloads using a
diff <(...) <(...)checksum check, which showed intermittent failures on GitHub macOS runners. E.g.https://github.com/y-scope/clp/actions/runs/23596584755/job/68714868001?pr=2093
From the logs, the failure is attributed to
remote:curlat the end of execution:However,
remote:curlitself appears to run to completion, reaching the final checksum step:There is no clear indication of why the diff command failed. More broadly, these intermittent failures are difficult to interpret in interleaved logs produced by the parallel execution of
deps:coretasks, where the task fails without clearly surfacing the root cause.A different bug
https://github.com/y-scope/clp/actions/runs/23913577520/job/69741617703?pr=2170
deps:spdlogfailed inremote:download-and-extract-tarduringgtar --extractwith exit status 2.The suspicious part is that
remote:curlforspdlog-extracted.tar.gzwas marked up-to-date, but this log has no actual successful spdlog download step. So one plausible cause is a false-positive status check inremote:curl, which still usesdiff <(...) <(...)with process substitution. If that incorrectly accepts a bad cached tarball, extraction would fail next.We still don’t know the exact gtar error because stderr is suppressed by 2> /dev/null.
Feature
This PR improves the debuggability of failures in
remote:curlby replacing the final checksum diff in the cmds path with explicit checks and clearer error reporting.remote:curlnow:This change does not alter the task’s success behavior. It only improves observability when checksum verification fails, making it easier to diagnose and reproduce the underlying issue, which will be addressed in a follow up bug fix PR.
Checklist
breaking change.
Validation performed
task tests:remotepasses.Summary by CodeRabbit