Skip to content

Remove yShrink#177

Merged
thomasbehr merged 22 commits intomasterfrom
strip_shrinker
Mar 18, 2026
Merged

Remove yShrink#177
thomasbehr merged 22 commits intomasterfrom
strip_shrinker

Conversation

@Fohlen
Copy link
Copy Markdown
Member

@Fohlen Fohlen commented Mar 4, 2026

No description provided.

@Fohlen Fohlen marked this pull request as draft March 4, 2026 07:29
@Fohlen Fohlen marked this pull request as ready for review March 4, 2026 08:10
@Fohlen
Copy link
Copy Markdown
Member Author

Fohlen commented Mar 4, 2026

Hiya @thomasbehr I believe this is ready for review and to be merged to land in yGuard 5x

@Fohlen
Copy link
Copy Markdown
Member Author

Fohlen commented Mar 4, 2026

Unfortunately its a HUGE MR so take your time chunk by chunk. Essentially I believe anything inside com.yworks.yshrink and associated tests can be ignored, and the rest needs a bit of examination...

@thomasbehr thomasbehr merged commit 71337b0 into master Mar 18, 2026
4 checks passed
@thomasbehr thomasbehr deleted the strip_shrinker branch March 18, 2026 09:24
@thomasbehr
Copy link
Copy Markdown
Member

@Fohlen Had to "revive" the shrinking model, because it is needed for handling "extends" and "implements" attributes of the "keep" element. I did not change the analyzer and model implementations which means the model collects unnecessary data about invocations, etc., but since this only happens when someone actually uses "extends" or "implements" and it has always been like that for renaming without shrinking, I think this is fine for now.

thomasbehr added a commit that referenced this pull request Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants