Merged
Conversation
Contributor
Author
|
I've done some limited testing and the asset seems to be working fine, although someone could do a deeper dive to make sure. |
Owner
|
Thank you for the PR. I believe it's sufficient to change |
Contributor
Author
|
Tested it on my end, seems to be working fine, thanks for the suggestion! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not entirely sure if this is all that should be done, it gets rid of all the errors tho.
I can't test yet as I have many other assets with errors so half the engine is not working.