Open
Conversation
Contributor
WhatDamon
commented
Mar 20, 2026
WhatDamon
commented
Contributor
There was a problem hiding this comment.
Pull request overview
将“仅 Linux/FreeBSD 可用”的系统支持提示从选项标题中移出，改为通过 subtitle 展示，以改善“当前系统不适用的选项”列表的可读性与对齐效果。
Changes:
- 移除
use_native_glfw/openal各语言标题中的[Linux/FreeBSD Only]前缀文本 - 新增统一的 i18n 文案键
settings.advanced.linux_freebsd_only - 在
AdvancedVersionSettingPage中为两个开关设置 subtitle 为上述新键对应的文本
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| HMCL/src/main/resources/assets/lang/I18N.properties | 新增 settings.advanced.linux_freebsd_only 并调整两项标题文本 |
| HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties | 同步标题调整并新增 settings.advanced.linux_freebsd_only |
| HMCL/src/main/resources/assets/lang/I18N_zh.properties | 同步标题调整并新增 settings.advanced.linux_freebsd_only |
| HMCL/src/main/resources/assets/lang/I18N_uk.properties | 同步标题调整并新增 settings.advanced.linux_freebsd_only |
| HMCL/src/main/resources/assets/lang/I18N_ru.properties | 同步标题调整并新增 settings.advanced.linux_freebsd_only |
| HMCL/src/main/resources/assets/lang/I18N_lzh.properties | 同步标题调整并新增（但键名存在拼写问题） |
| HMCL/src/main/resources/assets/lang/I18N_ja.properties | 同步标题调整并新增 settings.advanced.linux_freebsd_only |
| HMCL/src/main/resources/assets/lang/I18N_es.properties | 同步标题调整并新增 settings.advanced.linux_freebsd_only |
| HMCL/src/main/resources/assets/lang/I18N_ar.properties | 同步标题调整并新增 settings.advanced.linux_freebsd_only |
| HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/AdvancedVersionSettingPage.java | 为两个选项设置 subtitle：settings.advanced.linux_freebsd_only |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| settings.advanced.use_native_openal=[惟磷若/FreeBSD] 用開聲庫 | ||
| settings.advanced.use_native_glfw=用 GLFW | ||
| settings.advanced.use_native_openal=用開聲庫 | ||
| settings.adcanced.linux_freebsd_only=惟磷若/FreeBSD |
There was a problem hiding this comment.
In I18N_lzh.properties the new key is spelled settings.adcanced.linux_freebsd_only, but the UI looks up settings.advanced.linux_freebsd_only. This will cause Classical Chinese locale to fall back / log MissingResourceException for this subtitle. Rename the key to settings.advanced.linux_freebsd_only to match the other locales and the Java lookup.
Suggested change
| settings.adcanced.linux_freebsd_only=惟磷若/FreeBSD | |
| settings.advanced.linux_freebsd_only=惟磷若/FreeBSD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.