540 sftp does not download the file then errors#546
Merged
Hirogen merged 4 commits intoDevelopmentfrom Mar 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several improvements and fixes across the codebase. The main changes focus on improving robustness for file handling (especially with SFTP and plugin-based filesystems), updating localization resources, and modernizing versioning and build configuration. Additionally, a new test class ensures correct behavior when file system plugins return null, preventing possible exceptions.
File handling robustness and SFTP improvements: #540
RolloverFilenameHandler.GetNameListandSftpLogFileInfoto prevent crashes when plugins or SFTP operations fail (e.g., when files do not exist or permissions are denied). This includes returningfalseif a plugin or file info is missing, and logging errors for SFTP exceptions. [1] [2] [3]RolloverFilenameHandlerNullTeststo verify thatGetNameListdoes not throw exceptions in edge cases, such as when plugins return null or when rollover files are missing.Localization and resource updates: #544
Build and versioning modernization: #542
Directory.Build.props, and improved assembly info generation settings. Also updated company name and release notes URL. [1] [2]AppVersionto be passed via the command line or read from the built executable, aligning with automated build systems. [1] [2]AssemblyInfo.csin favor of project file configuration.Minor code quality and bug fixes:
LogWindow.GetPersistenceDataby checking if_logFileReaderis not null before accessing its properties.These changes collectively improve the stability, maintainability, and user experience of the application.