Chore: [AEA-0000] - bump dev container and handle zizmor not existing#140
Chore: [AEA-0000] - bump dev container and handle zizmor not existing#140anthony-nhs merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the devcontainer image version and makes the devcontainer quality-checks workflow resilient to missing zizmor in the container image.
Changes:
- Bump devcontainer base image version from
v1.4.4tov1.4.8. - Guard the workflow step that copies
zizmorinto/usr/local/binso it doesn’t fail when the binary is absent.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/quality-checks-devcontainer.yml |
Adds a conditional check before copying the zizmor binary to avoid failing when it’s not present. |
.devcontainer/devcontainer.json |
Updates the devcontainer build arg IMAGE_VERSION to v1.4.8. |
| else | ||
| echo "zizmor not found at /home/vscode/.local/bin/zizmor; skipping copy" |
There was a problem hiding this comment.
The new guard prevents the copy step from failing when zizmor is missing, but the workflow still runs make zizmor unconditionally later. If the binary truly isn’t present in the container, the job will still fail at the Run zizmor step. Consider setting an env/output flag here and using it to conditionally run the zizmor step (or installing zizmor when missing).
| else | |
| echo "zizmor not found at /home/vscode/.local/bin/zizmor; skipping copy" | |
| elif command -v zizmor >/dev/null 2>&1; then | |
| echo "zizmor already available on PATH; no copy required" | |
| elif command -v cargo >/dev/null 2>&1; then | |
| cargo install --root "$HOME/.local" zizmor | |
| sudo cp "$HOME/.local/bin/zizmor" /usr/local/bin/zizmor | |
| else | |
| echo "zizmor is not available in the container and could not be installed automatically" >&2 | |
| exit 1 |
|
Summary
Details
bump dev container
handle zizmor binary not existing