Skip to content

Chore: [AEA-0000] - bump dev container and handle zizmor not existing #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthony-nhs merged 1 commit into from
Apr 16, 2026
Merged

Chore: [AEA-0000] - bump dev container and handle zizmor not existing #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"args": {
"DOCKER_GID": "${env:DOCKER_GID:}",
"IMAGE_NAME": "node_24_python_3_14",
"IMAGE_VERSION": "v1.4.4",
"IMAGE_VERSION": "v1.4.8",
"USER_UID": "${localEnv:USER_ID:}",
"USER_GID": "${localEnv:GROUP_ID:}"
},
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/quality-checks-devcontainer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,11 @@ jobs:
cp /home/vscode/.tool-versions "$HOME/.tool-versions"
cp /home/vscode/.grant.yaml "$HOME/.grant.yaml"
mkdir -p "$HOME/.local/bin"
sudo cp /home/vscode/.local/bin/zizmor /usr/local/bin/zizmor
if [ -f /home/vscode/.local/bin/zizmor ]; then
sudo cp /home/vscode/.local/bin/zizmor /usr/local/bin/zizmor
else
echo "zizmor not found at /home/vscode/.local/bin/zizmor; skipping copy"
Comment on lines +52 to +53
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new guard prevents the copy step from failing when zizmor is missing, but the workflow still runs make zizmor unconditionally later. If the binary truly isn’t present in the container, the job will still fail at the Run zizmor step. Consider setting an env/output flag here and using it to conditionally run the zizmor step (or installing zizmor when missing).

Suggested change
else
echo "zizmor not found at /home/vscode/.local/bin/zizmor; skipping copy"
elif command -v zizmor >/dev/null 2>&1; then
echo "zizmor already available on PATH; no copy required"
elif command -v cargo >/dev/null 2>&1; then
cargo install --root "$HOME/.local" zizmor
sudo cp "$HOME/.local/bin/zizmor" /usr/local/bin/zizmor
else
echo "zizmor is not available in the container and could not be installed automatically" >&2
exit 1

Copilot uses AI. Check for mistakes.
fi

- &checkout
name: Checkout code
Expand Down