added more descriptive error message for acls#709
Open
SharonStrats wants to merge 4 commits intomainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves the user-facing error message shown when a dropped URI can’t be classified as a valid ACL agent/group/origin in the Access Groups UI (per issue #121), by adding more guidance and including detected RDF types.
Changes:
- Collect detected RDF types for the dropped URI and append them to the failure message.
- Replace the previous generic drop failure message with a more descriptive “expected types + hint” error.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
timea-solid
approved these changes
Mar 16, 2026
TallTed
reviewed
Mar 16, 2026
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket SolidOS/solidos#121
It may not always be a group and there's no way to tell which type it should be without changing the parameters and that would cause regression issues. So msg is a bit wordy.