Skip to content

added more descriptive error message for acls #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SharonStrats wants to merge 4 commits into
base: main
Choose a base branch
from
Open

added more descriptive error message for acls #709

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1949085
added more descriptive error message for acls
SharonStrats Mar 15, 2026
b1d4405
Potential fix for pull request finding
timea-solid Mar 16, 2026
bdc4495
Potential fix for pull request finding
timea-solid Mar 16, 2026
b0f35f1
Update src/acl/access-groups.ts
timea-solid Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/acl/access-groups.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,15 @@ export class AccessGroups {
}
return this.handleDroppedUri(uri, combo, true)
} else if (!agent) {
const error = ` Error: Drop fails to drop appropriate thing! ${uri}`
const detectedTypes = Object.keys(this.store.findTypeURIs(thing))
const typeDetails = detectedTypes.length > 0
? `Detected RDF types: ${detectedTypes.join(', ')}`
: 'No RDF type was detected for this URI.'
const error =
`Error: Failed to add access target: ${uri} is not a recognized ACL target type.` +
` Expected one of: vcard:WebID, vcard:Group, foaf:Person, foaf:Agent, solid:AppProvider, solid:AppProviderClass, or recognized ACL classes.` +
' Hint: try dropping a WebID profile URI, a vcard:Group URI, or a web app origin.' +
typeDetails
debug.error(error)
return Promise.reject(new Error(error))
}
Expand Down