fix: clean up Route53 provider, remove wildcard domain support#2
Closed
fix: clean up Route53 provider, remove wildcard domain support#2
Conversation
- Trim verbose docstrings in route53.py - Fix typos in DNS_PROVIDERS.md Route53 notes - Add missing volumes block to Route53 compose example - Add route53 to DNS_PROVIDER choices list - Remove wildcard domain handling (cert_dir_name, wildcard TXT prefix, wildcard CAA issuewild tag) from entrypoint.sh and functions.sh - Remove Wildcard Domain Support section from README - Use DOMAIN directly for cert paths instead of cert_dir_name Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5 tasks
Owner
Author
|
No longer needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
route53.pyDNS_PROVIDERS.mdvolumes:block to Route53 compose exampleroute53toDNS_PROVIDERchoices listcert_dir_name, wildcard TXT prefix, wildcard CAAissuewildtag) — useDOMAINdirectly for cert pathsFiles Changed
scripts/dns_providers/route53.pyscripts/entrypoint.sh${DOMAIN}for cert pathsscripts/functions.shcert_dir_name()scripts/generate-evidences.sh${domain}directlyDNS_PROVIDERS.mdroute53to choices, fix typos, add missing volumesREADME.mdTest plan
${DOMAIN}Cherry-picked from Dstack-TEE/dstack-examples#83
Tracks: CPL-139
🤖 Generated with Claude Code