Merged
Conversation
This reverts commit 6deb283.
jeff-hykin
requested changes
Apr 16, 2026
Member
jeff-hykin
left a comment
jeff-hykin
left a comment
There was a problem hiding this comment.
32000000 in a var, then it looks good to me
leshy
previously approved these changes
Apr 17, 2026
jeff-hykin
approved these changes
Apr 21, 2026
leshy
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Mac UDP limits are too low. It appears newer releases now support 32 MiB.
Solution
To continue supporting higher limits in future releases, this code tries to set the actual target threshold and then keeps halving and retrying until it works, thus allowing us to use the maximum available on each system. (The max is a compiled-in constant to the kernel and is not exposed anywhere).
How to Test
Run sim/replay on Mac OS X.