Add support for pipe2 API. NFC#26480
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Mar 18, 2026
Merged
Conversation
Becuase we support pipe already we already support the flags=0 version of pipe2. Simply deleting the definition of `SYS_pipe` musl will use `__syscall_pipe2` for both `pipe` and `pipe2`. See emscripten-core#14824 (this doesn't fix the issue but works around the specific instance of it).
kripken
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Becuase we support
pipealready we already support theflags=0version ofpipe2.Simply deleting the definition of
SYS_pipemusl will use__syscall_pipe2for bothpipeandpipe2.See #14824 (this doesn't fix the issue but works around the specific instance of it).