Fix Issue #1089: Don't optimize Option Compare Text empty string#1232
Merged
GrahamTheCoder merged 1 commit intomasterfrom Mar 14, 2026
Merged
Fix Issue #1089: Don't optimize Option Compare Text empty string#1232GrahamTheCoder merged 1 commit intomasterfrom
GrahamTheCoder merged 1 commit intomasterfrom
Conversation
…ks to string.IsNullOrEmpty() Under Option Compare Text, Visual Basic evaluates certain invisible character strings as equal to `""`. Optimizing this down to `string.IsNullOrEmpty` in C# breaks correct behavior because C# considers these strings non-empty. This commit skips the null/empty optimization when `OptionCompareTextCaseInsensitive` is true, causing it to fall back to `CultureInfo.CurrentCulture.CompareInfo.Compare` logic. Co-authored-by: GrahamTheCoder <2490482+GrahamTheCoder@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Issue #1089: Don't optimize Option Compare Text empty string checks to string.IsNullOrEmpty()
Under Option Compare Text, Visual Basic evaluates certain invisible character strings as equal to
"". Optimizing this down tostring.IsNullOrEmptyin C# breaks correct behavior because C# considers these strings non-empty. This commit skips the null/empty optimization whenOptionCompareTextCaseInsensitiveis true, causing it to fall back toCultureInfo.CurrentCulture.CompareInfo.Comparelogic.