Skip to content

Fix Issue #1089: Don't optimize Option Compare Text empty string #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GrahamTheCoder merged 1 commit into from
Mar 14, 2026
+8 −2
Merged

Fix Issue #1089: Don't optimize Option Compare Text empty string #1232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CodeConverter/CSharp/VisualBasicEqualityComparison.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,12 @@ private static ObjectCreationExpressionSyntax NewStringFromArg(ExpressionSyntax
public bool TryConvertToNullOrEmptyCheck(VBSyntax.BinaryExpressionSyntax node, ExpressionSyntax lhs,
ExpressionSyntax rhs, out CSharpSyntaxNode? visitBinaryExpression)
{
if (OptionCompareTextCaseInsensitive)
{
visitBinaryExpression = null;
return false;
}

bool lhsEmpty = IsNothingOrEmpty(node.Left);
bool rhsEmpty = IsNothingOrEmpty(node.Right);

Expand Down
4 changes: 2 additions & 2 deletions Tests/CSharp/ExpressionTests/StringExpressionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,11 +208,11 @@ public void Foo()
{
throw new Exception();
}
if (string.IsNullOrEmpty(s1))
if (CultureInfo.CurrentCulture.CompareInfo.Compare(s1 ?? """", """", CompareOptions.IgnoreCase | CompareOptions.IgnoreKanaType | CompareOptions.IgnoreWidth) == 0)
{
//
}
if (string.IsNullOrEmpty(s1))
if (CultureInfo.CurrentCulture.CompareInfo.Compare(s1 ?? """", """", CompareOptions.IgnoreCase | CompareOptions.IgnoreKanaType | CompareOptions.IgnoreWidth) == 0)
{
//
}
Expand Down
Loading