feat: split LogoutListener from AttributeListener by denischilik · Pull Request #685 · mParticle/mparticle-android-sdk

denischilik · 2026-03-27T18:21:09Z

Summary

Introduces KitIntegration.LogoutListener as a separate contract from the deprecated AttributeListener.
KitManagerImpl.logout() invokes logout() only on kits that implement LogoutListener.
All embedded kits that previously implemented AttributeListener now explicitly implement LogoutListener as well.
AttributeListenerTestKit implements both interfaces for instrumented tests.

Introduce KitIntegration.LogoutListener for logout handling; AttributeListener no longer extends it. KitManagerImpl calls logout() on LogoutListener only. Embedded kits that implement AttributeListener now explicitly implement LogoutListener; AttributeListenerTestKit updated accordingly.

cursor · 2026-03-27T18:21:15Z

PR Summary

Medium Risk
Changes the kit API contract for logout handling and updates build/version resolution for kit modules, which could cause kits to miss logout callbacks or resolve the wrong android-kit-base artifact if not implemented/configured correctly.

Overview
Decouples logout handling from KitIntegration.AttributeListener. Introduces a new LogoutListener interface, removes logout() from the deprecated AttributeListener, and updates KitManagerImpl.logout() to call logout only on kits that implement LogoutListener.

Updates embedded kits/tests to match the new contract. Kits that previously relied on AttributeListener.logout() now explicitly implement LogoutListener (and the AttributeListenerTestKit does as well).

Stabilizes kit CI builds against local published artifacts. Workflows now publish/use a -ci version via -PVERSION=...-ci, and Gradle/KitPlugin are updated to resolve android-kit-base using the root VERSION property (with a root-level resolution strategy for kit subprojects) to avoid accidentally pulling an older Maven artifact.

^{Written by Cursor Bugbot for commit 48c71fe. This will update automatically on new commits. Configure here.}

Kotlin CI failed resolving import com.mparticle.kits.KitIntegration.LogoutListener for Java nested interfaces; use KitIntegration.LogoutListener in implements lists. Made-with: Cursor

thomson-t · 2026-03-27T18:51:11Z

kits/branch/branch-5/src/main/kotlin/com/mparticle/kits/BranchMetricsKit.kt

    EventListener,
    CommerceListener,
    AttributeListener,
+    KitIntegration.LogoutListener,


Would be nice to import the class and use just.

Suggested change

KitIntegration.LogoutListener,

LogoutListener,

Our Kotlin builds failed on CI with Unresolved reference 'LogoutListener' when we used import com.mparticle.kits.KitIntegration.LogoutListener

Looks like kits during tests were using released version and it was original reason for failure

Yes, when the repos were separate, the core will be published first and the kits will consume it to get the updates in interfaces and contracts.
That need to be changed in new flow.

Ensures settings-kits.gradle resolves android-kit-base from the same version published to mavenLocal, not the latest from Maven Central. Made-with: Cursor

Use import com.mparticle.kits.KitIntegration.LogoutListener and LogoutListener in kit implementations and KitManagerImpl instead of qualified KitIntegration.LogoutListener. Made-with: Cursor

KitPlugin resolves android-kit-base via VERSION; isolated UA runs from a subproject previously omitted -PVERSION and fell back to '+' (Central). Run from repo root with -p and -PVERSION aligned with VERSION file. Made-with: Cursor

Export VERSION from VERSION file to GITHUB_ENV so Gradle resolves the same project property without repeating -PVERSION on every command. Made-with: Cursor

- Append -ci to ORG_GRADLE_PROJECT_VERSION so kit resolution cannot match an already-published Central artifact for the same semver. - Run publish + kit + urbanairship in one run block with export so every Gradle invocation shares the same VERSION property. Made-with: Cursor

Revert merging multiple kit Gradle commands into a single run block. Keep ORG_GRADLE_PROJECT_VERSION=$(head -n 1 VERSION)-ci so kits resolve local maven artifacts that do not exist on Central. Made-with: Cursor

GITHUB_ENV ORG_GRADLE_PROJECT_VERSION was not reliably applied when using settings-kits.gradle; KitPlugin then fell back to '+' and resolved android-kit-base from Maven Central. Pass -PVERSION=...-ci on each publish, lint, ktlint, test, and urbanairship invocation. Made-with: Cursor

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

cursor · 2026-03-27T21:22:59Z

kits/adobe/adobe-5/src/main/kotlin/com/mparticle/kits/AdobeKitBase.kt

        val dBlob = dBlob
        val dcsRegion = dcsRegion
+        val userIdentities =
+            MParticle.getInstance()?.Identity()?.getCurrentUser()?.getUserIdentities() ?: emptyMap()


Unfiltered user identities sent to Adobe kit

High Severity

The newly added userIdentities variable fetches identities via MParticle.getInstance()?.Identity()?.getCurrentUser()?.getUserIdentities(), which returns unfiltered identities from the raw MParticleUser. The KitIntegration base class provides getCurrentUser() which returns a FilteredMParticleUser — its getUserIdentities() applies both data plan filtering and kit configuration filtering (via shouldSetIdentity). Using the unfiltered path bypasses these controls and may send identity types to Adobe that the dashboard configuration has explicitly blocked.

sonarqubecloud · 2026-03-27T21:25:08Z

Quality Gate failed

Failed conditions
8.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

denischilik added 2 commits March 27, 2026 13:53

Simplify code

ed12758

denischilik requested a review from a team as a code owner March 27, 2026 18:21

fix(kits): reference KitIntegration.LogoutListener without nested import

22710db

Kotlin CI failed resolving import com.mparticle.kits.KitIntegration.LogoutListener for Java nested interfaces; use KitIntegration.LogoutListener in implements lists. Made-with: Cursor

thomson-t reviewed Mar 27, 2026

View reviewed changes

thomson-t previously approved these changes Mar 27, 2026

View reviewed changes

ci: pass -PVERSION to kit lint and ktlint in PR and daily workflows

357e115

Ensures settings-kits.gradle resolves android-kit-base from the same version published to mavenLocal, not the latest from Maven Central. Made-with: Cursor

denischilik dismissed thomson-t’s stale review via 357e115 March 27, 2026 19:54

denischilik added 6 commits March 27, 2026 15:56

refactor: import KitIntegration.LogoutListener for short name usage

c5a469a

Use import com.mparticle.kits.KitIntegration.LogoutListener and LogoutListener in kit implementations and KitManagerImpl instead of qualified KitIntegration.LogoutListener. Made-with: Cursor

ci: set Gradle VERSION via ORG_GRADLE_PROJECT_VERSION for kit jobs

e7d3b44

Export VERSION from VERSION file to GITHUB_ENV so Gradle resolves the same project property without repeating -PVERSION on every command. Made-with: Cursor

ci: restore separate Gradle steps; keep VERSION-ci via GITHUB_ENV

aecf127

Revert merging multiple kit Gradle commands into a single run block. Keep ORG_GRADLE_PROJECT_VERSION=$(head -n 1 VERSION)-ci so kits resolve local maven artifacts that do not exist on Central. Made-with: Cursor

denischilik force-pushed the feat/remove-attribute-listener branch from 5d009a2 to 4848718 Compare March 27, 2026 20:52

cursor bot reviewed Mar 27, 2026

View reviewed changes

denischilik force-pushed the feat/remove-attribute-listener branch from 48c71fe to 4848718 Compare March 27, 2026 21:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: split LogoutListener from AttributeListener#685

feat: split LogoutListener from AttributeListener#685
denischilik wants to merge 10 commits intoworkstation/6.0-Releasefrom
feat/remove-attribute-listener

denischilik commented Mar 27, 2026

Uh oh!

cursor bot commented Mar 27, 2026 •

edited

Loading

Uh oh!

thomson-t Mar 27, 2026

Uh oh!

denischilik Mar 27, 2026

Uh oh!

denischilik Mar 27, 2026

Uh oh!

thomson-t Mar 27, 2026

Uh oh!

cursor bot left a comment

Uh oh!

cursor bot Mar 27, 2026

Uh oh!

sonarqubecloud bot commented Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

denischilik commented Mar 27, 2026

Summary

Uh oh!

cursor bot commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

thomson-t Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

denischilik Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

denischilik Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

thomson-t Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Mar 27, 2026

Choose a reason for hiding this comment

Unfiltered user identities sent to Adobe kit

Uh oh!

sonarqubecloud bot commented Mar 27, 2026

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cursor bot commented Mar 27, 2026 •

edited

Loading