-
Notifications
You must be signed in to change notification settings - Fork 69
feat: split LogoutListener from AttributeListener #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
denischilik
merged 22 commits into
workstation/6.0-Release
from
feat/remove-attribute-listener
Mar 30, 2026
+139
−50
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
09bfee2
feat: split LogoutListener from AttributeListener
denischilik ed12758
Simplify code
denischilik 22710db
fix(kits): reference KitIntegration.LogoutListener without nested import
denischilik 357e115
ci: pass -PVERSION to kit lint and ktlint in PR and daily workflows
denischilik c5a469a
refactor: import KitIntegration.LogoutListener for short name usage
denischilik 920067a
ci: pass -PVERSION to isolated urbanairship kit Gradle steps
denischilik e7d3b44
ci: set Gradle VERSION via ORG_GRADLE_PROJECT_VERSION for kit jobs
denischilik a3d3efa
update trunk
denischilik cda6792
fix(kits): resolve com.mparticle from mavenLocal only when flag set
denischilik 59a2532
fix(kit-plugin): resolve android-kit-base VERSION from root project
denischilik 5a82036
ci: pass -Pversion to kit workflow Gradle commands
denischilik fe4f3ec
fix(kit-plugin): correct exclusiveContent mavenLocal repository refer…
denischilik 910204c
fix(kit-plugin): use content filters for mavenLocal-only group resolu…
denischilik e6883d9
fix(adobe-kit): use currentUser identities in ID sync
denischilik eb91c39
fix(leanplum-kit): use current user identities in ID generation
denischilik 727765e
ci: use local mparticle version for isolated urbanairship jobs
denischilik 43d7f82
fix(kit-plugin): clear inherited repositories in local-only mode
denischilik 3bbc708
style(kits): use short listener names in inheritance lists
denischilik 43c15f0
fix(adobe-kit): null-safe current user identities lookup
denischilik 1432a25
refactor(kit-plugin): simplify google repository filtering
denischilik d544369
fix(android-kit-base-tests): remove unused KitIntegration import
denischilik 161aae1
ci: align workflow Gradle version property injection
denischilik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 4 additions & 2 deletions
6
...d-kit-base/src/androidTest/kotlin/com/mparticle/kits/testkits/AttributeListenerTestKit.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,19 +31,22 @@ import com.mparticle.commerce.Product | |
| import com.mparticle.consent.ConsentState | ||
| import com.mparticle.internal.Logger | ||
| import com.mparticle.internal.MPUtility | ||
| import com.mparticle.kits.KitIntegration.LogoutListener | ||
| import org.json.JSONArray | ||
| import org.json.JSONException | ||
| import org.json.JSONObject | ||
| import java.math.BigDecimal | ||
| import java.util.LinkedList | ||
| import com.mparticle.kits.KitIntegration.AttributeListener | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will trigger lint errors since the imports are not sorted. Something we can fix when the lint is unified across all the kits. |
||
|
|
||
| /** | ||
| * mParticle Kit wrapper for the AppsFlyer SDK | ||
| */ | ||
| class AppsFlyerKit : | ||
| KitIntegration(), | ||
| KitIntegration.EventListener, | ||
| KitIntegration.AttributeListener, | ||
| AttributeListener, | ||
| LogoutListener, | ||
| KitIntegration.CommerceListener, | ||
| AppsFlyerConversionListener, | ||
| KitIntegration.ActivityListener, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.