Skip to content

Make MSBuild extension more strict #7525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evangelink merged 6 commits into from
Mar 12, 2026
+152 −1
Merged

Make MSBuild extension more strict #7525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
75517f3
Make MSBuild extension more strict
Youssef1313 Mar 11, 2026
25f9583
Error when TestingPlatformDotnetTestSupport is true, but IsTestingPla…
Youssef1313 Mar 11, 2026
c601e32
Simplify
Youssef1313 Mar 11, 2026
33499b4
Update src/Platform/Microsoft.Testing.Platform.MSBuild/buildMultiTarg…
Youssef1313 Mar 12, 2026
49320a7
Update src/Platform/Microsoft.Testing.Platform.MSBuild/Tasks/InvokeTe…
Youssef1313 Mar 12, 2026
a2a2caa
Update InvokeTestingPlatformTask.cs
Youssef1313 Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/MSBuildResources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,4 +164,10 @@ You can resolve the problem by installing the '{1}' .NET.
The specified framework can be found at:
- https://aka.ms/dotnet-download</value>
</data>
<data name="DidNotReceiveModuleInfo" xml:space="preserve">
<value>MSBuild extension failed to receive test application information from '{0}'</value>
</data>
<data name="DidNotReceiveRunSummaryInfo" xml:space="preserve">
<value>MSBuild extension failed to receive test run summary from '{0}'</value>
</data>
</root>
10 changes: 10 additions & 0 deletions src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@
<target state="translated">Skutečná hodnota: {0}</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveModuleInfo">
<source>MSBuild extension failed to receive test application information from '{0}'</source>
<target state="new">MSBuild extension failed to receive test application information from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveRunSummaryInfo">
<source>MSBuild extension failed to receive test run summary from '{0}'</source>
<target state="new">MSBuild extension failed to receive test run summary from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="ExpectedValue">
<source>Expected value: {0}</source>
<target state="translated">Očekávaná hodnota: {0}</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@
<target state="translated">Tatsächlicher Wert: {0}</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveModuleInfo">
<source>MSBuild extension failed to receive test application information from '{0}'</source>
<target state="new">MSBuild extension failed to receive test application information from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveRunSummaryInfo">
<source>MSBuild extension failed to receive test run summary from '{0}'</source>
<target state="new">MSBuild extension failed to receive test run summary from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="ExpectedValue">
<source>Expected value: {0}</source>
<target state="translated">Erwarteter Wert: {0}</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@
<target state="translated">Valor real: {0}</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveModuleInfo">
<source>MSBuild extension failed to receive test application information from '{0}'</source>
<target state="new">MSBuild extension failed to receive test application information from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveRunSummaryInfo">
<source>MSBuild extension failed to receive test run summary from '{0}'</source>
<target state="new">MSBuild extension failed to receive test run summary from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="ExpectedValue">
<source>Expected value: {0}</source>
<target state="translated">Valor esperado: {0}</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@
<target state="translated">Valeur réelle : {0}</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveModuleInfo">
<source>MSBuild extension failed to receive test application information from '{0}'</source>
<target state="new">MSBuild extension failed to receive test application information from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveRunSummaryInfo">
<source>MSBuild extension failed to receive test run summary from '{0}'</source>
<target state="new">MSBuild extension failed to receive test run summary from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="ExpectedValue">
<source>Expected value: {0}</source>
<target state="translated">Valeur attendue : {0}</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@
<target state="translated">Valore effettivo: {0}</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveModuleInfo">
<source>MSBuild extension failed to receive test application information from '{0}'</source>
<target state="new">MSBuild extension failed to receive test application information from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveRunSummaryInfo">
<source>MSBuild extension failed to receive test run summary from '{0}'</source>
<target state="new">MSBuild extension failed to receive test run summary from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="ExpectedValue">
<source>Expected value: {0}</source>
<target state="translated">Valore previsto: {0}</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.ja.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@
<target state="translated">実際の値: {0}</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveModuleInfo">
<source>MSBuild extension failed to receive test application information from '{0}'</source>
<target state="new">MSBuild extension failed to receive test application information from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveRunSummaryInfo">
<source>MSBuild extension failed to receive test run summary from '{0}'</source>
<target state="new">MSBuild extension failed to receive test run summary from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="ExpectedValue">
<source>Expected value: {0}</source>
<target state="translated">想定された値: {0}</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.ko.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@
<target state="translated">실제 값: {0}</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveModuleInfo">
<source>MSBuild extension failed to receive test application information from '{0}'</source>
<target state="new">MSBuild extension failed to receive test application information from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveRunSummaryInfo">
<source>MSBuild extension failed to receive test run summary from '{0}'</source>
<target state="new">MSBuild extension failed to receive test run summary from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="ExpectedValue">
<source>Expected value: {0}</source>
<target state="translated">예상 값: {0}</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.pl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@
<target state="translated">Wartość rzeczywista: {0}.</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveModuleInfo">
<source>MSBuild extension failed to receive test application information from '{0}'</source>
<target state="new">MSBuild extension failed to receive test application information from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveRunSummaryInfo">
<source>MSBuild extension failed to receive test run summary from '{0}'</source>
<target state="new">MSBuild extension failed to receive test run summary from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="ExpectedValue">
<source>Expected value: {0}</source>
<target state="translated">Oczekiwana wartość: {0}.</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.pt-BR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@
<target state="translated">Valor real: {0}</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveModuleInfo">
<source>MSBuild extension failed to receive test application information from '{0}'</source>
<target state="new">MSBuild extension failed to receive test application information from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveRunSummaryInfo">
<source>MSBuild extension failed to receive test run summary from '{0}'</source>
<target state="new">MSBuild extension failed to receive test run summary from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="ExpectedValue">
<source>Expected value: {0}</source>
<target state="translated">Valor esperado: {0}</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.ru.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@
<target state="translated">Действительное значение: {0}</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveModuleInfo">
<source>MSBuild extension failed to receive test application information from '{0}'</source>
<target state="new">MSBuild extension failed to receive test application information from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveRunSummaryInfo">
<source>MSBuild extension failed to receive test run summary from '{0}'</source>
<target state="new">MSBuild extension failed to receive test run summary from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="ExpectedValue">
<source>Expected value: {0}</source>
<target state="translated">Ожидаемое значение: {0}</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.tr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@
<target state="translated">Gerçek değer: {0}</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveModuleInfo">
<source>MSBuild extension failed to receive test application information from '{0}'</source>
<target state="new">MSBuild extension failed to receive test application information from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveRunSummaryInfo">
<source>MSBuild extension failed to receive test run summary from '{0}'</source>
<target state="new">MSBuild extension failed to receive test run summary from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="ExpectedValue">
<source>Expected value: {0}</source>
<target state="translated">Beklenen değer: {0}</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.zh-Hans.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@
<target state="translated">实际值: {0}</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveModuleInfo">
<source>MSBuild extension failed to receive test application information from '{0}'</source>
<target state="new">MSBuild extension failed to receive test application information from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveRunSummaryInfo">
<source>MSBuild extension failed to receive test run summary from '{0}'</source>
<target state="new">MSBuild extension failed to receive test run summary from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="ExpectedValue">
<source>Expected value: {0}</source>
<target state="translated">预期的值: {0}</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.zh-Hant.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@
<target state="translated">實際值: {0}</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveModuleInfo">
<source>MSBuild extension failed to receive test application information from '{0}'</source>
<target state="new">MSBuild extension failed to receive test application information from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="DidNotReceiveRunSummaryInfo">
<source>MSBuild extension failed to receive test run summary from '{0}'</source>
<target state="new">MSBuild extension failed to receive test run summary from '{0}'</target>
<note />
</trans-unit>
<trans-unit id="ExpectedValue">
<source>Expected value: {0}</source>
<target state="translated">預期的值: {0}</target>
Expand Down
14 changes: 14 additions & 0 deletions src/Platform/Microsoft.Testing.Platform.MSBuild/Tasks/InvokeTestingPlatformTask.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ public class InvokeTestingPlatformTask : Build.Utilities.ToolTask, IDisposable

private Task? _connectionLoopTask;
private ModuleInfoRequest? _moduleInfo;
private bool _receivedRunSummaryInfoRequest;
private string? _outputFileName;
private StreamWriter? _outputFileStream;
private string? _toolCommand;
Expand Down Expand Up @@ -388,6 +389,18 @@ public override bool Execute()

if (returnValue)
{
if (_moduleInfo is null)
{
Log.LogError(Resources.MSBuildResources.DidNotReceiveModuleInfo, TargetPath.ItemSpec.Trim());
return false;
}

if (!_receivedRunSummaryInfoRequest)
{
Log.LogError(Resources.MSBuildResources.DidNotReceiveRunSummaryInfo, TargetPath.ItemSpec.Trim());
return false;
}

Log.LogMessage(MessageImportance.High, Resources.MSBuildResources.TestsSucceeded, TargetPath.ItemSpec.Trim(), TargetFramework.ItemSpec, TestArchitecture.ItemSpec);
}

Expand Down Expand Up @@ -514,6 +527,7 @@ private Task<IResponse> HandleRequestAsync(IRequest request)
Log.LogMessage(MessageImportance.High, summary);
}

_receivedRunSummaryInfoRequest = true;
return Task.FromResult<IResponse>(VoidResponse.CachedInstance);
}

Expand Down
3 changes: 2 additions & 1 deletion ...ng.Platform.MSBuild/buildMultiTargeting/Microsoft.Testing.Platform.MSBuild.VSTest.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<Project>
<!-- Override VSTest target for single tfm -->
<Target Name="VSTest">
<CallTarget Targets="InvokeTestingPlatform" />
<Error Text="'TestingPlatformDotnetTestSupport' was set to true, but the project did not opt-in MTP. If this is not a test project, set 'IsTestingPlatformApplication' to false. For more information, see https://aka.ms/migrate-vstest-mtp" Condition="'$(IsTestingPlatformApplication)' != 'true'" />
<CallTarget Targets="InvokeTestingPlatform" Condition="'$(IsTestingPlatformApplication)' == 'true'" />
</Target>
</Project>
Loading