test: wait for ok before initial break after restart#62807
Open
inoway46 wants to merge 1 commit intonodejs:mainfrom
Open
test: wait for ok before initial break after restart#62807inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46 wants to merge 1 commit intonodejs:mainfrom
Conversation
28b3e0e to
3a7bcb0
Compare
This was referenced Apr 19, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62807 +/- ##
==========================================
- Coverage 89.69% 89.68% -0.01%
==========================================
Files 706 706
Lines 218222 218222
Branches 41768 41779 +11
==========================================
- Hits 195731 195712 -19
- Misses 14411 14414 +3
- Partials 8080 8096 +16 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to: #62471
Waiting for
Debugger attached.beforewaitForInitialBreak()reduced one race, but it still was not a strong enough sync point. During reconnect,debug>can be re-displayed before the CLI finishesrun()/restart(), and the output can still look like:This change waits for
okbeforewaitForInitialBreak(), so the test only starts waiting for the initial break after the CLI has completed reconnecting.CI logs
Testing
./tools/test.py -p actions -j1 --repeat 50 parallel/test-debugger-run-after-quit-restartRefs: #61762