fix(api): return 400 instead of 500 for hostname validation errors #343
Codecov / codecov/project
succeeded
Apr 2, 2026 in 1s
99.91% (+0.00%) compared to ed04edc
View this Pull Request on Codecov
99.91% (+0.00%) compared to ed04edc
Details
Codecov Report
❌ Patch coverage is 97.05882% with 2 lines in your changes missing coverage. Please review.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| internal/controller/api/node/user/user_update.go | 50.00% | 1 Missing and 1 partial |
@@ Coverage Diff @@
## main #343 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 438 438
Lines 21239 21268 +29
=======================================
+ Hits 21220 21249 +29
Misses 11 11
Partials 8 8 | Files with missing lines | Coverage Δ | |
|---|---|---|
| internal/controller/api/file/file_upload.go | 97.64% <ø> (ø) |
|
| internal/controller/api/job/job_list.go | 100.00% <ø> (+4.08%) |
⬆️ |
| ...ernal/controller/api/node/certificate/ca_delete.go | 100.00% <100.00%> (ø) |
|
| ...nal/controller/api/node/certificate/ca_list_get.go | 100.00% <100.00%> (ø) |
|
| internal/controller/api/node/log/log_query_get.go | 100.00% <100.00%> (ø) |
|
| internal/controller/api/node/log/log_source_get.go | 100.00% <100.00%> (ø) |
|
| internal/controller/api/node/log/log_unit_get.go | 100.00% <100.00%> (ø) |
|
| internal/controller/api/node/ntp/ntp_delete.go | 100.00% <100.00%> (ø) |
|
| internal/controller/api/node/ntp/ntp_get.go | 100.00% <100.00%> (ø) |
|
| ...nternal/controller/api/node/package/package_get.go | 100.00% <100.00%> (ø) |
|
| ... and 33 more |
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update ed04edc...d15d9d1. Read the comment docs.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Loading