Skip to content

fix(api): return 400 instead of 500 for hostname validation errors #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
retr0h merged 7 commits into from
Apr 2, 2026
Merged

fix(api): return 400 instead of 500 for hostname validation errors #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
aa510cd
fix(api): return 400 instead of 500 for hostname validation errors
retr0h Apr 2, 2026
3b5adb2
test(api): add missing HTTP body validation wiring tests
retr0h Apr 2, 2026
8cccab2
fix(api): add missing validate tags and handler validation calls
retr0h Apr 2, 2026
ce1e333
docs: regenerate OpenAPI docs with updated 400 responses
retr0h Apr 2, 2026
a05ee52
fix(api): reject empty update bodies with 400
retr0h Apr 2, 2026
f47386f
refactor(validation): use AtLeastOneField for empty body checks
retr0h Apr 2, 2026
d15d9d1
chore(api): remove redundant limit cap and stale comments
retr0h Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 92 additions & 1 deletion docs/docs/gen/api/delete-node-certificate-ca.api.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: "Delete a CA certificate from the target node."
sidebar_label: "Delete a CA certificate"
hide_title: true
hide_table_of_contents: true
api: eJztV0tv20YQ/iuLQQ8JupLlVE4bAT2oiYO6SIogdRCgriqMuCNxbXKX3R06VgT+92KWkkw9iqRpAvSQk0hxnt+8V2AoZsFWbL2DETyjgpgUqqdjlVFgO7cZMql58KXinBRjWBAr5w31/3CggXERYXQFT++ppy/R4YJKcjwdv7qYdgRNfUUBRVmEiYbt24XZKv/VG+oIe4qgIVJWB8tLGF2t4CfCQGFccy56O8JH74Jlgkkz0VBhwJKYQkw8DkuCEeQ+cnrUYMXdCjkHDYH+qm0gAyMONek9TC5bl3FBjtVGglaBIoVbMir4mq1bqFssalIPpuiWWk2xKB5q5YMqcEaFilRQxj6oBze0HCXShy2Adz2Ple1l3tCCXI/uOGCvRXUFt1hYgyy2b4zUpXU/nur0ZdqGAxoNMcupROHhZSX0kYN1C9BQWveC3ELgOm0avQXjXwPRiYoS5r56WUdWmXeM1inviqXCosrR1SUFm6ksx4CZBEGr2hkKMfOBolbojMqXVU4u/hcQPt5vSQhmCuLGn1fYez/u/T7oPZn2Jt9+A40kTKBYeRcpaXw0GMjPnvu7JWFStpo+aBAEyLGwYFUV8t16d3IdhW91aKKfXVPGoKEKUgFsW63Xfja15pgrcx9KZBhBXVsDBwmak7r2M3XxTNWRjGKvquAzilFxbqMS0CiyWEp3WFaFyD47G9APw8GgR4+ezHrDUzPs4fenj3vD4ePHZ2fD4WAwGAi+gWJdcOxYhSHgUhKHqYzHvNq17nUSoPz8sKtkgZBJq7oy6deHNapq2xjU3AflHaXC6x9Ati3oI6DtmvHzmlIMkUbWljPnyBuwBDmBa6u7n/KLket4TD65upQO5G8kQmgLktDEG1tVZKS7HUapFbYxYdfJpLv1stHwcU4dVKSwZjm6BXXzaOZ9QegO2N/mxDmFPWNKb+zcklFxGZnKZHQrmULw4cNWnQuZKilGXJCyXbxbmPrQNN1mc9VtzGvAJxrYckrV7jQYv6w5mXnuOCyh2Re0SdcPsb9el7tIaDQMB6eHBf/GYc25D/Y9GdVT41cX6oaWaqvusxX+R+I6Vp33TRIl3jaPfZbVIbQt6b7QnyfIpSkE4mDpdpOGKaSGGG1xNL/3lBtj5RELteZROPM13xtxVK2pSVQ74nc+3Ci2Jfm6TXFp9h291jEtKBztbq2TwrCj5GwwkOBtAp3y7iCw3x0G9rkPM2sMOdVTFy7W87nNrKRnRaG0Mab15Gt0///RPTs2p9v2kwaJrGW7M+czjuuvcf1CcW00lMS5l5ug3QdAtxvqCE7k8jhZbeZFc9KJ7UmGJ6v0bzoZwm27/U/u74ffJLRt9LpXxNabnLmC9U6ZBmciAr1+eL5Zw355e5lGmHVzn9jXvozTkLs/f2RmgAYxpIXltD/op7Wq8pFLTPm2Xsf/4fTaR3Z1n76fcq21fjLd8UlVoHViSx0KkdsifAVCDRpGnZm8a08mJ9kofZroNLqFbbWaYaQ3oWga+fuvmsKyRf8Wg8WZAHS1AmOjPBsYzbGI+zdG17sHr9eD9qH6wifYUVQ2266TXTdRwwhAww0tu5ekHFSf5NMXvKY+wZ/Wl0mjISc0FFKs2k/jLKOKO0wHTVPup23FPjt/cX55Dhpwt7b2aikpOGrTatVSXPobck2zNZHlXWxsmr8BLcLKWw==
api: eJztWG2P00YQ/iurUT+AusnlaI6WSP0Q4FCvggrRQ0i9ptHEO4mXs3fd3fFxIfJ/r2ad5JyXCkqLRCU+xS87b88zM57JCgzFLNiKrXcwgqdUEJNC9WSsMgps5zZDJjUPvlSck2IMC2LlvKH+7w40MC4ijK7gyd3p6Qt0uKCSHE/HLy+mHUVTX1FAMRZhomF7d2G2xn/xhjrKniBoiJTVwfISRlcreEwYKIxrzsVuR/noXbBMMGkmGioMWBJTiEnGYUkwgtxHTpcarIRbIeegIdCftQ1kYMShJr2HyWUbMi7Isdpo0CpQpHBDRgVfs3ULdYNFTereFN1SqykWxX2tfFAFzqhQkQrK2Ad175qWo3T0fgvgbc9jZXuZN7Qg16NbDthrUV3BDRbWIIvvGyd1ad2Ppzq9mbZ0QKMhZjmVKDK8rOR85GDdAjSU1j0ntxC4TptGb8H4x0B0WFEi3Fcv6sgq847ROuVdsVRYVDm6uqRgM5XlGDATErSqnaEQMx8oaoXOqHxZ5eTivwHh4+OWhGCmIGH8cYW99+Peb4Peo2lv8u030EjCBIqVd5GSxQeDgfzshb9bEiZlq+mDBkGAHIsIVlUh7613J2+jyK0OXfSzt5QxaKiCVADb1upbP5tacyyUuQ8lMoygrq2BgwTNSb31M3XxVNWRjGKvquAzilFxbqMS0CiyeEq3WFaF6D47G9APw8GgRw8ezXrDUzPs4fenD3vD4cOHZ2fD4WAwGAi+gWJdcOx4hSHgUhKHqYzHotr17lVSoPz8sKtkgZBJq7oy6deHNapq2xjU3AflHaXC6x9Ati3oI6DtuvHT+qQ4Io2sLWfOkTdgCXIC19Z2P+UXI9fxmH5ydSkdyF8LQ2gLEmrita0qMtLdDllqlW1c2A0y2W6jbDR8XFAHFSmiWY5uQd08mnlfELoD8Tc5cU5hz5nSGzu3ZFRcRqYyOd1qphB8+LBX53JMlRQjLkjZLt4tTH1omm6zueo25jXgEw1sOaVq92swflFzcvPccVhCs69ok64fEn+1LnfR0GgYHiv4x2g2taN6at2FBKGEw39Y+B+J61h17jdJlGTbPPZZVofQtqS7Qn+WIJemEIiDpZtNGiZKDTHa4mh+7xk3xsolFmoto3Dma75z4qhZU5OYdsTvfLhWbEvydZvi0uw7dq1jWlA42t3aIEVgx8jZYCDkbYhOeXdA7Okhsa8d1pz7YN+TUT01fnmhrmmptnn0ldj/A7HfHRL7zIeZNYac6qkLF+v53GZW+k5FobQxprnzK7tfPrtnx/px+11JE4LM27vDxNd2/OXz2mgoiXMvy1476IFuV48RnMhKebLaDALNSYfbkwxPVulp2gXDTbvWTe4Ww1+F2pa97nq4jSZnrmC9LKSJKB0Cvb54tpmvf35zmWYT6+Y+ia9jGafp5W6vlW8GaBBHWlhO+4N+mpcrH7nElG/rPetvdup9ZFd36fspa3gbJ9Mtn1QFWie+1KEQvS3CVyCnQcOoM2zt+pPJrj1KryY6zWQitlrNMNLrUDSNPP6zprBs0b/BYHEmAF2twNgo1wZGcyzi/vLYje7eq/WH9r76zLv1UVQ2a4yTJSadhhGAhmtadv8ikE35k2L6jGvyJ8TTxjJpNOSEhkLiqn01zjKquCN00DRlMd5W7NPz5+eX56ABd2trr5aSgaM+rVbtiUt/Ta5pti6y3IuPTfMXq4NvGQ==
sidebar_class_name: "delete api-method"
info_path: gen/api/agent-management-api
custom_edit_url: null
Expand Down Expand Up @@ -255,6 +255,97 @@ Delete a CA certificate from the target node.
</MimeTabs>
</div>
</TabItem><TabItem
label={"400"}
value={"400"}
>
<div>


Bad request - validation error.


</div><div>
<MimeTabs
className={"openapi-tabs__mime"}
schemaType={"response"}
>
<TabItem
label={"application/json"}
value={"application/json"}
>
<SchemaTabs
className={"openapi-tabs__schema"}
>
<TabItem
label={"Schema"}
value={"Schema"}
>
<details
style={{}}
className={"openapi-markdown__details response"}
data-collapsed={false}
open={true}
>
<summary
style={{}}
className={"openapi-markdown__details-summary-response"}
>
<strong>
Schema
</strong>
</summary><div
style={{"textAlign":"left","marginLeft":"1rem"}}
>

</div><ul
style={{"marginLeft":"1rem"}}
>
<SchemaItem
collapsible={false}
name={"error"}
required={false}
schemaName={"string"}
qualifierMessage={undefined}
schema={{"type":"string","description":"A description of the error that occurred.","example":"Failed to retrieve status."}}
>

</SchemaItem><SchemaItem
collapsible={false}
name={"details"}
required={false}
schemaName={"string"}
qualifierMessage={undefined}
schema={{"type":"string","description":"Additional details about the error.","example":"Failed due to network timeout."}}
>

</SchemaItem><SchemaItem
collapsible={false}
name={"code"}
required={false}
schemaName={"integer"}
qualifierMessage={undefined}
schema={{"type":"integer","description":"The error code.","example":500}}
>

</SchemaItem>
</ul>
</details>
</TabItem><TabItem
label={"Example (from schema)"}
value={"Example (from schema)"}
>
<ResponseSamples
responseExample={"{\n \"error\": \"Failed to retrieve status.\",\n \"details\": \"Failed due to network timeout.\",\n \"code\": 500\n}"}
language={"json"}
>

</ResponseSamples>
</TabItem>
</SchemaTabs>
</TabItem>
</MimeTabs>
</div>
</TabItem><TabItem
label={"401"}
value={"401"}
>
Expand Down
93 changes: 92 additions & 1 deletion docs/docs/gen/api/delete-node-group.api.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: "Delete a group from the target node."
sidebar_label: "Delete a group"
hide_title: true
hide_table_of_contents: true
api: eJztV99v2zYQ/leIe0oB2lE6J9sE7CFD0y1DOxRdgj5khkGLZ4uxRKrkKY1n6H8fjrQdxfa2pmuBDeiTJet+fPfdHXm3Ao2h8KYh4yzk8AIrJBRKzL1rGzHzrhZUoiDl50jCOo3D3y1IIDUPkN/AdUA/UVZPfmKFyWtl1RxrtDQ5f3M5iVYmrkGv2EGAsYTt26XeOvzVaYwGQELAovWGlpDfrOBHVB79eUslO2sD+vyDN4Qw7sYSGuVVjYQ+RGGraoQcShcoPkowHFOjqAQJHt+3xqOGnHyLcifwqxSgmqMlsbEghceA/g618K4lY+fiTlUtiqOJskspJqqqnknhvKjUFCsRsMKCnBdHC1zmUfRZout+4FRjBoXTOEc7wHvyapA4XMGdqoxWxNg3IGVt7A8nMn6ZJPKhkxCKEmvFOrRsWD6QN3YOEmpjX6GdM08nXSe3ZDyZiJgGwWr/BvlTwI4ZUmicDRiNPs8y/jkES8dq0UOQUDhLaIklVdNUpog1dXwbWHy179xNb7EgkNB4rkAyydmtm06MPgRy5nytCHJoW6Nhr15KFLduKi5fiDagFuRE412BIQgqTRBMBwZipHiv6qZi26enGX43yrIBPv9+Ohid6NFAfXtyNhiNzs5OT0ejLMsyZs5jaCsKPVTKe7XkPBLW4VBUj9G9jQaEm207ufCoCKVoGx1/nV+TKbb9KGbOC2cxlv9wj6ltWx3g6rH3n9eS7J8Pj9RUVCracMSEMUtb38NYMKSoDYfso21rPgDcghOjTIWckbAwTYOaD5X95CRjGwiPg4y+U5SdhI8LqtcXrFSUys6xXzhT5ypUdk/xXYlUot+BUTttZga1CMtAWEe4yTJ67/w/47lgMVFjCGqOwvSZTgQNoev6zX7TPxjXVI8lkKFYmzG+1y1FeKl+oNu1sCnMv9GLfcyanYRRdrLfyddWtVQ6b/5ALQbi/M2lWOBSbN18ttb+SCLPRe99Uy9RN5WsK4rW+3ToPLTyy8gxt71H8gbvNhUXc6iRlKkOlvKOc60NP6pKrHWEmrqWHkAcdKtbZNcW6YPzC0GmRtemauaDuufXWMI5+oPnVwqSFR45Oc0yTt4mwbHQ9hL7zX5iXzo/NVqjFQNxaUM7m5nCcD026GsTQhwAvmb3/5Dd0V9dwNaRmLnWfs4r+Gsmv1gmTw+NUunmiLc/T7RxPviazv9+OjsJNVLpeG1KsxtzzzN9Dse8mR2vNjd8dxyzeryKL3Gp8ndpTRo/bFi/cUZT0vp71jaIkiguZFGMJ5woBHL98HIzIP/y7irOGsbOXFRfh3Aep5GHlZDvepDAQBIbJ8NsGAfexgWqVSyz9d7yeBHd5XH1UKxPWFlTVIT3dNxUylj23PqKzSUab4ClQULeG5U2APL4PpZxjGLZ1WqqAl77quv47/ct+mUi+E55o6bMwc0KtAn8rCGfqSrs7lv9SI7ermegZ+ILr6MHqdisGpYXjSgNOYCEBS77WzUvl58U0+5m+QkgEoBxJ6FEpdFHgtOn86LAhnpKe2cYL5rbBnpx8eri6gIkqMc1v1Pj0cFBTKtVkrhyC7Rdt4VI/M4Yu+5P0akB5g==
api: eJztWN9v2zYQ/leIe0oB2nE6p9sE7CFFky1DOxRdij5khkGLZ4uxRKrkKY1n6H8fjrQcxfa2tmuBFciTJft+fPfdHX3HNWgMuTc1GWchgxdYIqFQYuFdU4u5d5WgAgUpv0AS1mkc/mFBAqlFgOwa3gb0U2X19GdWmL5SVi2wQkvTs9eX02hl6mr0ih0EmEjYvl3qrcPfnMZoACQEzBtvaAXZ9Rqeo/Lozxoq2FkT0GcfvCGESTuRUCuvKiT0IQpbVSFkULhA8VGC4ZhqRQVI8Pi+MR41ZOQblDuBX6UA1QItic6CFB4D+lvUwruGjF2IW1U2KI6myq6kmKqyfCKF86JUMyxFwBJzcl4cLXGVRdEnia67gVO1GeRO4wLtAO/Iq0HicA23qjRaEWPvQMrK2J9OZPxlmsiHVkLIC6wU69CqZvlA3tgFSKiMfYl2wTydtK3ckvHJRMQ0CFb7L8g/BeyEIYXa2YDR6NPRiD8OwdKxWvQQJOTOElpiSVXXpcljTR3fBBZf7zt3sxvMCSTUniuQTHJ242ZTow+BnDtfKYIMmsZo2KuXAsWNm4nLF6IJqAU5UXuXYwiCChME04GBGCneqaou2fbp6Qh/GI9GA3z642wwPtHjgfr+5NlgPH727PR0PB6NRiNmzmNoSgo9VMp7teI8ElbhUFQP0b2JBoSbbzs596gIpWhqHT+d35Aptv0o5s4LZzGW/3CPqW1bHeDqofdfNpLsnw+P1FRUKOo4YsKYpa3vYSwYUtSEQ/bRNhUfAG7JiVGmRM5IWJq6Rs2Hyn5ykrEOwsMgo+8UZSvh44Lq9QUr5YWyC+wXzsy5EpXdU3xXIBXod2BUTpu5QS3CKhBWEW6yjN47/+94zllMVBiCWqAwfaYTQUNo236zX/cPxg3VEwlkKNZmjO9VQxFeqh9ody10hfkPerGPWbOVMD7Uyc+V7rpDDMTmBGFKYuBfsLU/ksgz0Xvv6iXqppJ1ed54nw6d+1a+iBxz23skb/C2q7iYQ42kTHmwlHeca234UZVioyPUzDV0D+KgW90gu7ZIH5xfCjIVuiZVMx/UPb/GEi7QHzy/UpCs8MDJ6WjEyesSHAttL7En+4l9a1VDhfPmT9RiIM5eX4olrsS2fh4T+y0k9rv9xF44PzNaoxUDcWlDM5+b3PBBU6OvTAhxsnvM7reQ3fHfTVbWkZi7xn7J2eoxk18tk6eH/lnTSBDHOl5V4uD3mM7/fzpbCRVS4XgfTkM5c8/LWgbHvHIfr7vRrT2OWT1ex5e4LfvbtP9O7lfn3zmjKWn9BXobREEUN+0oxqNrFAK5ebjoNp9f313FIdLYuYvqmxDO4ph5v+vzfz1IYCCJjZPhaBg3mdoFqlQss81C+vCGYZfH9X2xfsJdRIqK8I6O61IZy54bX7K5ROM1sDRIyHozcAcgi+8TGedjll2vZyrgW1+2LX/9vkG/SgTfKm/UjDm4XoM2gZ81ZHNVht1Fuh/J0ZvNDPREfOV7hoNUdDuk5Q0ySkMGIGGJq/51Cd8afFZMu1cGnwEiAZi0EgpUGn0kOP10ludYU09p7wzjG4RtA704f3l+dQ4S1MOa36nx6OAgpvU6SVy5Jdq23UIkfmeMbfsXt1WmlQ==
sidebar_class_name: "delete api-method"
info_path: gen/api/agent-management-api
custom_edit_url: null
Expand Down Expand Up @@ -255,6 +255,97 @@ Delete a group from the target node.
</MimeTabs>
</div>
</TabItem><TabItem
label={"400"}
value={"400"}
>
<div>


Bad request - validation error.


</div><div>
<MimeTabs
className={"openapi-tabs__mime"}
schemaType={"response"}
>
<TabItem
label={"application/json"}
value={"application/json"}
>
<SchemaTabs
className={"openapi-tabs__schema"}
>
<TabItem
label={"Schema"}
value={"Schema"}
>
<details
style={{}}
className={"openapi-markdown__details response"}
data-collapsed={false}
open={true}
>
<summary
style={{}}
className={"openapi-markdown__details-summary-response"}
>
<strong>
Schema
</strong>
</summary><div
style={{"textAlign":"left","marginLeft":"1rem"}}
>

</div><ul
style={{"marginLeft":"1rem"}}
>
<SchemaItem
collapsible={false}
name={"error"}
required={false}
schemaName={"string"}
qualifierMessage={undefined}
schema={{"type":"string","description":"A description of the error that occurred.","example":"Failed to retrieve status."}}
>

</SchemaItem><SchemaItem
collapsible={false}
name={"details"}
required={false}
schemaName={"string"}
qualifierMessage={undefined}
schema={{"type":"string","description":"Additional details about the error.","example":"Failed due to network timeout."}}
>

</SchemaItem><SchemaItem
collapsible={false}
name={"code"}
required={false}
schemaName={"integer"}
qualifierMessage={undefined}
schema={{"type":"integer","description":"The error code.","example":500}}
>

</SchemaItem>
</ul>
</details>
</TabItem><TabItem
label={"Example (from schema)"}
value={"Example (from schema)"}
>
<ResponseSamples
responseExample={"{\n \"error\": \"Failed to retrieve status.\",\n \"details\": \"Failed due to network timeout.\",\n \"code\": 500\n}"}
language={"json"}
>

</ResponseSamples>
</TabItem>
</SchemaTabs>
</TabItem>
</MimeTabs>
</div>
</TabItem><TabItem
label={"401"}
value={"401"}
>
Expand Down
Loading
Loading