test: add test coverage for untested function#385
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
==========================================
+ Coverage 69.72% 69.97% +0.24%
==========================================
Files 220 220
Lines 18446 18446
==========================================
+ Hits 12862 12907 +45
+ Misses 4410 4364 -46
- Partials 1174 1175 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b6186e8 to
5d93f6c
Compare
Accept main's test naming conventions (Test_Foo pattern) and more comprehensive test implementations. Remove duplicate tests that were added on this branch but already existed in main.
Member
Author
|
Closing - all of these tests have been brought in by other PRs and the remaining tests are out-dated or handled by upcoming PRs related to the areas (e.g. style and formatter). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Summary
This pull request attempts to increase our test coverage closer to 70% by focusing on files that do not require mocks or refactors to be tested.
internal/pkg/platform/activity.gowhere the deployment activity string produced "deployd" instead of "deployed" and caused a linter warning for the test-case.Requirements