Skip to content

test: add test coverage for untested function#385

Closed
mwbrooks wants to merge 2 commits intomainfrom
mwbrooks-test-coverage-simple
Closed

test: add test coverage for untested function#385
mwbrooks wants to merge 2 commits intomainfrom
mwbrooks-test-coverage-simple

Conversation

@mwbrooks
Copy link
Member

Changelog

  • N/A

Summary

This pull request attempts to increase our test coverage closer to 70% by focusing on files that do not require mocks or refactors to be tested.

  • Added new test files: context getters/setters, recursive copy, image processing, archive utilities, API collaborators, prompt permissions, and datastore queries.
  • Extended existing test files: activity formatting, survey configs, error handling, style functions, version management, OS wrappers, and HTTP client options.
  • Fix a typo in internal/pkg/platform/activity.go where the deployment activity string produced "deployd" instead of "deployed" and caused a linter warning for the test-case.

Requirements

@mwbrooks mwbrooks added this to the Next Release milestone Mar 11, 2026
@mwbrooks mwbrooks self-assigned this Mar 11, 2026
@mwbrooks mwbrooks added code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment labels Mar 11, 2026
@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.97%. Comparing base (1065713) to head (42c677f).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
+ Coverage   69.72%   69.97%   +0.24%     
==========================================
  Files         220      220              
  Lines       18446    18446              
==========================================
+ Hits        12862    12907      +45     
+ Misses       4410     4364      -46     
- Partials     1174     1175       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mwbrooks mwbrooks force-pushed the mwbrooks-test-coverage-simple branch from b6186e8 to 5d93f6c Compare March 12, 2026 03:48
@mwbrooks mwbrooks changed the title test: increase code coverage from 65% to 70% test: add test coverage for untested function Mar 12, 2026
@mwbrooks mwbrooks modified the milestones: v3.15.0, Next Release Mar 13, 2026
Accept main's test naming conventions (Test_Foo pattern) and
more comprehensive test implementations. Remove duplicate tests
that were added on this branch but already existed in main.
@mwbrooks
Copy link
Member Author

Closing - all of these tests have been brought in by other PRs and the remaining tests are out-dated or handled by upcoming PRs related to the areas (e.g. style and formatter).

@mwbrooks mwbrooks closed this Mar 20, 2026
@mwbrooks mwbrooks deleted the mwbrooks-test-coverage-simple branch March 20, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant