Skip to content

test: add test coverage for untested function #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mwbrooks wants to merge 2 commits into from
Closed

test: add test coverage for untested function #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d93f6c
test: add test coverage for untested functions
mwbrooks Mar 12, 2026
42c677f
merge: resolve conflicts from main
mwbrooks Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions internal/api/app_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,3 +593,51 @@ func TestClient_DeveloperAppInstall_RequestAppApproval(t *testing.T) {
})
}
}

func TestClient_GetAppStatus_Ok(t *testing.T) {
ctx := slackcontext.MockContext(t.Context())
c, teardown := NewFakeClient(t, FakeClientParams{
ExpectedMethod: appStatusMethod,
Response: `{"ok":true,"apps":[{"app_id":"A123","status":"installed"}]}`,
})
defer teardown()
result, err := c.GetAppStatus(ctx, "token", []string{"A123"}, "T123")
require.NoError(t, err)
require.NotNil(t, result)
}

func TestClient_GetAppStatus_Error(t *testing.T) {
ctx := slackcontext.MockContext(t.Context())
c, teardown := NewFakeClient(t, FakeClientParams{
ExpectedMethod: appStatusMethod,
Response: `{"ok":false,"error":"invalid_app"}`,
})
defer teardown()
_, err := c.GetAppStatus(ctx, "token", []string{"A123"}, "T123")
require.Error(t, err)
require.Contains(t, err.Error(), "invalid_app")
}

func TestClient_ConnectionsOpen_Ok(t *testing.T) {
ctx := slackcontext.MockContext(t.Context())
c, teardown := NewFakeClient(t, FakeClientParams{
ExpectedMethod: appConnectionsOpenMethod,
Response: `{"ok":true,"url":"wss://example.com/ws"}`,
})
defer teardown()
result, err := c.ConnectionsOpen(ctx, "token")
require.NoError(t, err)
require.Equal(t, "wss://example.com/ws", result.URL)
}

func TestClient_ConnectionsOpen_Error(t *testing.T) {
ctx := slackcontext.MockContext(t.Context())
c, teardown := NewFakeClient(t, FakeClientParams{
ExpectedMethod: appConnectionsOpenMethod,
Response: `{"ok":false,"error":"token_revoked"}`,
})
defer teardown()
_, err := c.ConnectionsOpen(ctx, "token")
require.Error(t, err)
require.Contains(t, err.Error(), "token_revoked")
}
18 changes: 18 additions & 0 deletions internal/iostreams/writer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,24 @@ func Test_WriteIndent(t *testing.T) {
}
}

func Test_WriteOut(t *testing.T) {
fsMock := slackdeps.NewFsMock()
osMock := slackdeps.NewOsMock()
cfg := config.NewConfig(fsMock, osMock)
io := NewIOStreams(cfg, fsMock, osMock)
w := io.WriteOut()
require.NotNil(t, w)
}

func Test_WriteErr(t *testing.T) {
fsMock := slackdeps.NewFsMock()
osMock := slackdeps.NewOsMock()
cfg := config.NewConfig(fsMock, osMock)
io := NewIOStreams(cfg, fsMock, osMock)
w := io.WriteErr()
require.NotNil(t, w)
}

func Test_WriteSecondary(t *testing.T) {
tests := map[string]struct {
input string
Expand Down
14 changes: 7 additions & 7 deletions internal/pkg/platform/activity.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,9 +218,9 @@ func prettifyActivity(activity api.Activity) (log string) {

switch activity.Level {
case types.WARN:
return style.Yellow(msg)
return style.Styler().Yellow(msg).String()
case types.ERROR, types.FATAL:
return style.Red(msg)
return style.Styler().Red(msg).String()
}

return msg
Expand Down Expand Up @@ -280,7 +280,7 @@ func externalAuthResultToString(activity api.Activity) (result string) {
msg = msg + "\n\t\t" + strings.ReplaceAll(activity.Payload["extra_message"].(string), "\n", "\n\t\t")
}

return style.Gray(msg)
return style.Styler().Gray(13, msg).String()
}

func externalAuthStartedToString(activity api.Activity) (result string) {
Expand All @@ -298,7 +298,7 @@ func externalAuthStartedToString(activity api.Activity) (result string) {
msg = msg + "\n\t" + strings.ReplaceAll(activity.Payload["code"].(string), "\n", "\n\t")
}

return style.Gray(msg)
return style.Styler().Gray(13, msg).String()
}

func externalAuthTokenFetchResult(activity api.Activity) (result string) {
Expand All @@ -316,13 +316,13 @@ func externalAuthTokenFetchResult(activity api.Activity) (result string) {
msg = msg + "\n\t" + strings.ReplaceAll(activity.Payload["code"].(string), "\n", "\n\t")
}

return style.Gray(msg)
return style.Styler().Gray(13, msg).String()
}

func functionDeploymentToString(activity api.Activity) (result string) {
msg := fmt.Sprintf("Application %sd by user '%s' on team '%s'", activity.Payload["action"], activity.Payload["user_id"], activity.Payload["team_id"])
msg := fmt.Sprintf("Application %sed by user '%s' on team '%s'", activity.Payload["action"], activity.Payload["user_id"], activity.Payload["team_id"])
msg = fmt.Sprintf("%s %s [%s] %s", style.Emoji("cloud"), activity.CreatedPretty(), activity.Level, msg)
return style.Gray(msg)
return style.Styler().Gray(13, msg).String()
}

func functionExecutionOutputToString(activity api.Activity) (result string) {
Expand Down
Loading
Loading